Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not create char classes for NL characters for atBOL matching #682

Merged
merged 1 commit into from Dec 12, 2019
Merged

Conversation

lsf37
Copy link
Member

@lsf37 lsf37 commented Dec 12, 2019

the atBOL matching is done in the runtime engine on raw characters and doesn't go through the cmap, so we don't need to create classes for that case.

@lsf37 lsf37 requested review from regisd and sarowe as code owners Dec 12, 2019
@lsf37 lsf37 self-assigned this Dec 12, 2019
@lsf37 lsf37 added the enhancement Feature requests label Dec 12, 2019
@lsf37 lsf37 added this to the 1.8.0 milestone Dec 12, 2019
@lsf37
Copy link
Member Author

lsf37 commented Dec 12, 2019

In some cases this can lead to a coarser partition of the input set, which is good (leads to smaller tables and less memory use).

@lsf37 lsf37 changed the title do not create char classes of atBOL matching do not create char classes for NL characters atBOL matching Dec 12, 2019
@lsf37 lsf37 changed the title do not create char classes for NL characters atBOL matching do not create char classes for NL characters for atBOL matching Dec 12, 2019
The scanning engine is testing for newline on raw input characters without
translation through the char-class map, so there is no need for a separate
class in that case.
@lsf37 lsf37 merged commit 2b166cb into master Dec 12, 2019
@lsf37 lsf37 deleted the ccl branch Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant