-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make maven build reproducible #765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
Sorry for the delay, I need to read up a bit on what exactly maven is doing there to understand what we're doing. Reproducible build as such is a good idea, I'm all for it. |
@lsf37 don't hesitate to ping me if you need any explanation notice that Reproducible Central is now live and with many releases: https://github.com/jvm-repo-rebuild/reproducible-central |
I think using a timestamp is a bad practice, but it seems Maven can't do better. LGTM. |
As far as I understand, this will fix #720. I've updated the change description. |
you need something reproducible for files timestamp in zip archives: any better idea welcome :) |
no, i don't think so this PR is about getting the same binary JFlex |
(rebased and resolved conflicts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for pinging us to do that, and sorry that it took forever..
<project.build.outputTimestamp>
see https://maven.apache.org/guides/mini/guide-reproducible-builds.html