Allow java comment after yylexthrow #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` INFO: Found 2 targets... ERROR: /Users/regisd/Projects/jflex/javatests/jflex/testcase/yylexthrow_comment/BUILD.bazel:3:6: jflex javatests/jflex/testcase/yylexthrow_comment/Yylexthrow.java failed (Exit 1) jflex_bin failed: error executing command bazel-out/host/bin/jflex/jflex_bin -d bazel-out/darwin-fastbuild/bin/javatests/jflex/testcase/yylexthrow_comment javatests/jflex/testcase/yylexthrow_comment/yylexthrow.flex Use --sandbox_debug to see verbose messages from the sandbox Reading "javatests/jflex/testcase/yylexthrow_comment/yylexthrow.flex" Error in file "javatests/jflex/testcase/yylexthrow_comment/yylexthrow.flex" (line 9): %yylexthrow needs a list of (qualified) identifiers %yylexthrow Exception // comment on same line allowed ```
- Add the comment after the exception - Change type of AbstractLexer.lexThrown from String to List<String> Let the emitter do the formatting, instead of concatenating the exceptions in the flex file
regisd
force-pushed
the
yylexthrow_comment
branch
from
3fa6baf
to
cdd90b1
Compare
|
@lsf37 I think this fixes the described bug. I'm not sure whether There might be other ways, such as dropping the comment and only keep the identifier. Also, there might be other keywords to fix. What do you think? |
|
@lsf37 Can you have a look at this PR? It's not very complex, but it's changing jflex core and I don't want to submit without review. |
|
Thanks for doing this, I can look at it tomorrow and finish it off (if there is anything to be changed, which there probably isn't) |
|
My knownledge of the jflex grammar is not great. |
lsf37
approved these changes
Jan 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
%lexthrowkeyword can only be followed by identifiersThis change allows the identifier of the exception to be followed by a comment.
However, the emitter must also be adapter to emit one exception per line, otherwise the comment of the first might hide all the following declarations.
Also refactor the
AbstractLexScan.lexThrownfield fromStringtoList<String>, and let the emitter handle the formatting.Add an integration test.