Jack Flintermann
jflinter

Aug 25, 2016
@jflinter
  • @jflinter 9047852
    remove CFBundleExecutable from resources bundle
Aug 22, 2016
jflinter commented on pull request stripe/stripe-ios#410
@jflinter

Also, I'm not entirely sure I see what's going on here. Can you give me an example of an issue we missed that this is designed to catch?

Aug 22, 2016
jflinter commented on pull request stripe/stripe-ios#410
@jflinter

There's a lot of duplicate code here. Could you maybe move all of the code that's actually used in the assorted test apps (AppDelegate, MyAPIClient…

Aug 22, 2016
jflinter commented on pull request stripe/stripe-ios#410
@jflinter

Can you move the missing resource fixes + resource bundle check into a separate PR?

Aug 22, 2016
jflinter commented on pull request stripe/stripe-ios#410
@jflinter

It looks like you may have accidentally checked in Tests/installation_tests/manual_installation/ManualInstallationTest/Frameworks/StripeiOS-Static.zip

Aug 19, 2016
jflinter commented on pull request stripe/example-ios-backend#6
@jflinter

LGTM (assuming this actually works in practice)!

Aug 18, 2016
jflinter commented on issue jflinter/Dwifft#23
@jflinter

@elliottwilliams - thanks for the research; would you be interested in fixing it in a PR?

Aug 16, 2016
jflinter commented on pull request stripe/stripe-ios#405
@jflinter

Nice, that looks better to me! On Tue, Aug 16, 2016 at 3:27 PM, Ben Guo notifications@github.com wrote: Cool. Let's go with FormSheet [0] – it's n…

Aug 16, 2016
jflinter commented on pull request stripe/stripe-ios#405
@jflinter

Yeah, FullScreen SMS view controller looks bad. I'm open to anything that looks reasonable on both iPhone and iPad (it looks like the half-grey bac…

Aug 16, 2016
jflinter commented on pull request stripe/stripe-ios#405
@jflinter

Neat, this is cool. How does this work with the SMS code view controller?

Aug 16, 2016
jflinter commented on pull request stripe/stripe-ios#406
@jflinter

Nicely done; I like pulling all of that logic into a dedicated model class. Beyond maybe extracting into its own file, LGTM

Aug 16, 2016
jflinter commented on pull request stripe/stripe-ios#406
@jflinter

My weak preference would be to move this into a different file, but feel free to ignore.

Aug 13, 2016
jflinter commented on issue stripe/stripe-ios#382
@jflinter

@aasatt - we're having trouble reproducing this on our end. Can you send us a couple of things: The contents of your Podfile.lock If possible, a …

Aug 13, 2016
jflinter commented on pull request stripe/stripe-ios#404
@jflinter

Yeah I think they are doing so needlessly. :shrug: On Fri, Aug 12, 2016 at 4:55 PM, Brian Dorfman notifications@github.com wrote: In ci_scripts/ch…

Aug 13, 2016
jflinter commented on pull request stripe/stripe-ios#404
@jflinter

You can just set -e once at the top of the file; you don't have to prepend it to every line.

Aug 13, 2016
jflinter commented on pull request stripe/stripe-ios#404
@jflinter

Oh I also remembered! You need to add set -e here so that the script exits if the first check fails.

Aug 13, 2016
jflinter commented on pull request stripe/stripe-ios#402
@jflinter

Beyond my comments, lgtm

Aug 13, 2016
jflinter commented on pull request stripe/stripe-ios#402
@jflinter

I sorta think we should expose these icons publicly (a la templatedBrandImageForCardBrand); they'll be useful to some people.

Aug 13, 2016
jflinter commented on pull request stripe/stripe-ios#402
@jflinter

Since this color is now used in 2 places in this VC (it's also used in buildAttributedStringForCard:selected) can you pull it into a helper method …

Aug 13, 2016
jflinter commented on pull request stripe/stripe-ios#402
@jflinter

It looks like stp_card_applepay.png (and all the size variants) are the wrong size. They should match the other card icons (both in their dimension…

Aug 13, 2016
jflinter commented on pull request stripe/stripe-ios#404
@jflinter

LGTM

jflinter deleted branch jack-validate-zip at stripe/stripe-ios
Aug 12, 2016
Aug 12, 2016
@jflinter
Aug 12, 2016
jflinter merged pull request stripe/stripe-ios#403
@jflinter
Update ci_scripts to use export_builds command
1 commit with 31 additions and 13 deletions
Aug 12, 2016
jflinter opened pull request stripe/stripe-ios#403
@jflinter
Update ci_scripts to use export_builds command
1 commit with 31 additions and 13 deletions
Aug 12, 2016
Aug 12, 2016
jflinter commented on pull request stripe/stripe-ios#392
@jflinter

@bdorfman - I know I'm a little late to the party here. Do you think instead of NSAsserting here you could just squash the current value of payment…

Aug 12, 2016
jflinter commented on issue stripe/stripe-ios#401
@jflinter

Hey @keith @garnett - we're working on a fix for you guys here. Sorry for the trouble; we hope to have something in the next week or two.