Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker module name in build-info #617

Merged
merged 1 commit into from Feb 15, 2022
Merged

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Feb 15, 2022

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

Background
Currently, there are at least 2 ways to configure the Docker registry URL:

  1. Using a reverse proxy or using the full path to the repository: acme-docker-local.jfrog.io.
  2. Using URL to the Docker repository: acme.jfrog.io/docker-local

Expected
In the generated build-info, the module ID should be <image-name>/<image-tag>.

Actual
When configuring URL to Docker repository as a Docker registry, the module ID, in this case: docker-local/<image-name>/<image-tag>.

@yahavi yahavi self-assigned this Feb 15, 2022
@yahavi yahavi merged commit 997e40f into jfrog:master Feb 15, 2022
@yahavi yahavi deleted the docker-module branch February 15, 2022 14:12
@gangefors
Copy link

This pull request broke the module id name for any image that contains more than one slash.

See #665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants