Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined pull request ID in scan-pull-requests #428

Merged
merged 11 commits into from
Aug 10, 2023

Conversation

omerzi
Copy link
Member

@omerzi omerzi commented Aug 9, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

The PR ID was not correctly defined in scan-pull-requests, resulting in the failure of certain REST APIs.

@omerzi omerzi added bug Something isn't working safe to test Approve running integration tests on a pull request labels Aug 9, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 9, 2023
@omerzi omerzi requested a review from sverdlov93 August 9, 2023 14:35
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Aug 9, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 9, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Aug 9, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 9, 2023
…l-requests

# Conflicts:
#	commands/scanpullrequest/scanpullrequest.go
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Aug 9, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 9, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Aug 9, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 9, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Aug 9, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 9, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Aug 9, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 9, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Aug 9, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 9, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Aug 9, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

@omerzi omerzi merged commit 44854a2 into jfrog:dev Aug 10, 2023
10 of 11 checks passed
sverdlov93 pushed a commit to sverdlov93/frogbot that referenced this pull request Aug 13, 2023
sverdlov93 added a commit that referenced this pull request Aug 15, 2023
* improve docs

* improve docs

* improve docs

* improve docs

* improve docs

* improve docs

* improve docs

* Improve internal field names (#418)

* Fix aggregate PRs test (#420)

* Fix open pull request against the wrong branch (#421)

* Update Git Action dependencies (#427)

* Update git action

* Update git action

* Update git action

---------

Co-authored-by: Omer Zidkoni <omerz@jfrog.com>

* Restructure source code  (#419)

* Fix mock import (#429)

* Fix undefined pull request ID in scan-pull-requests (#428)

* Upgrade golang.org/x/net to 0.13.0 (#430)

* Remove base branch from github actions (#431)

* Separate env params extraction by context (#432)

* Update dependencies (#435)

* Update git action

* Update git action

* Update git action

* Update git action

* Update git action

* Update git action

* Update git action

* Update git action

* Unify webhook url markdown

* Update scan-pull-request.jenkinsfile

* Update scan-repository.jenkinsfile

* Update scan-pull-request.jenkinsfile

* add jenkins pipeline logo

* move position

* change image

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update install-github.md

* Delete jenkins-logo.png

* Update README.md

* Update README.md

* Update README.md

* Update git action

* Update git action

---------

Co-authored-by: Omer Zidkoni <omerz@jfrog.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Eyal Delarea <eyalde@jfrog.com>
Co-authored-by: Omer Zidkoni <50792403+omerzi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant