Add external dependencies rewrite parameters for helm remote repos #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fabianrindlisbacher
commented
Nov 3, 2022
fabianrindlisbacher
commented
- All tests passed. If this feature is not already covered by the tests, I added new tests.
- All static analysis checks passed.
- This pull request is on the dev branch.
- I used gofmt for formatting the code before submitting the pull request.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
fabianrindlisbacher
force-pushed
the
master
branch
from
c87f420
to
a8d9ece
Compare
|
I have read the CLA Document and I hereby sign the CLA |
|
The changes are needed to implement the new dependency rewrite functionality describe here: https://www.jfrog.com/confluence/display/JFROG/Kubernetes+Helm+Chart+Repositories -> Under Remote Repositories Would be great if these changes would be release asap, since we've got alot of our devs waiting for a feature that requires this flag. |
|
@eyalbe4 @sverdlov93 can you review these changes? |
github-actions
bot
removed
the
safe to test
yahavi
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.