Skip to content
Browse files

Fixed memory leak related bad reference counting.

IASKSpecifier objects were retaining
IASKSettingsReader object, which was the owner
of IASKSpecifier objects.

Fixed that by changing property in IASKSpecifier
to assign (from retain), and added settingsReader
to IASKAppSettingsViewController dealloc method.
  • Loading branch information...
1 parent bd5ce36 commit 6db6240ab4c377ebdbdc0349a320e228e83555f5 Arkadiusz Młynarczyk committed
View
1 InAppSettingsKit/Controllers/IASKAppSettingsViewController.m
@@ -165,6 +165,7 @@ - (void)dealloc {
[currentFirstResponder release];
currentFirstResponder = nil;
+ self.settingsReader = nil;
_delegate = nil;
[super dealloc];
View
2 InAppSettingsKit/Models/IASKSpecifier.h
@@ -24,7 +24,7 @@
IASKSettingsReader *_settingsReader;
}
@property (nonatomic, retain) NSDictionary *specifierDict;
-@property (nonatomic, retain) IASKSettingsReader *settingsReader;
+@property (nonatomic, assign) IASKSettingsReader *settingsReader;
- (id)initWithSpecifier:(NSDictionary*)specifier;
- (NSString*)title;
View
1 InAppSettingsKit/Models/IASKSpecifier.m
@@ -43,7 +43,6 @@ - (id)initWithSpecifier:(NSDictionary*)specifier {
- (void)dealloc {
[_specifierDict release];
[_multipleValuesDict release];
- [_settingsReader release];
_settingsReader = nil;
[super dealloc];

0 comments on commit 6db6240

Please sign in to comment.
Something went wrong with that request. Please try again.