Fix RbConfig / Config warning in Ruby 1.9.3. #11

Merged
merged 1 commit into from Nov 25, 2011

Conversation

Projects
None yet
Contributor

purcell commented Nov 6, 2011

"Config" is deprecated in Ruby 1.9.3, in favor of "RbConfig". This
patch uses whichever is available, preventing Ruby 1.9.3 from printing
a deprecation warning when redcloth is loaded.

This patch is similar to #10, but retains backwards compatibility with Ruby 1.9.2.

Fix RbConfig / Config warning in Ruby 1.9.3.
"Config" is deprecated in Ruby 1.9.3, in favor of "RbConfig". This
patch uses whichever is available, preventing Ruby 1.9.3 from printing
a deprecation warning when redcloth is loaded.

+1 :)

Yep, +1. My bad, thought RbConfig was older than it is.

@unclaimedbaggage unclaimedbaggage referenced this pull request Nov 7, 2011

Closed

1.9.3/config update #10

bgetting commented Nov 9, 2011

+1

+1

@ghost ghost referenced this pull request Nov 13, 2011

Closed

Use 'Rbconfig' on 1.9 #12

@ghost

ghost commented Nov 13, 2011

RbConfig is present since 1.9.1, as far as I can tell, but not present on 1.8.

Contributor

purcell commented Nov 13, 2011

Yeah, I guess just the deprecation warning is new to 1.9.3.

trans commented Nov 14, 2011

Is there any reason this hasn't been pulled yet?

Contributor

eagleas commented Nov 15, 2011

@jgarber update gem, please! :)

raroni commented Nov 17, 2011

+1 Looking forward to a version bump :)

meduza commented Nov 17, 2011

+1

deepj commented Nov 24, 2011

+1

It looks like gem needs new maintainer :) No response at all, amazing :)

Owner

jgarber commented Nov 25, 2011

Hi folks! :) I've been working 12 hours a day, no weekend, for the last two weeks on a site that needed to be up in advance of a nationally-televised event on Dec 1. It launched the day before Thanksgiving, then proceeded to go down around noon on Thanksgiving day while I was driving to relatives' house. Fun times. :-)

I'll be the first to admit, I've been a poor maintainer of RedCloth. It's gotten un-maintainable because Ragel is obscure and the parsing rules are complex. Nobody submits patches to the actual parsing code. Thus, I'm the bottleneck.

I want to change that with a "total rewrite":https://github.com/jgarber/redcloth-parslet in Parslet, but that takes time, which is difficult to make when there are long-time clients making requests. I'm going to Philly.rb hack nights to try and have a dedicated space to work on it. I'd love to have some collaborators!

Well, that came off a lot more defensive than I meant it to be! Here are a few more smileys to let you know I'm not a bad guy, just over-worked and under-rested. :-) :-) :-) :-)

I'll try to inspect the patch, test it on various Ruby versions and platforms, and push a version while my wife's getting ready to go this morning. Worst case, it will be sometime this weekend. I just want to do my due diligence so I don't have the back-and-forth flipping of a compiler flag that occurred with RedCloth on 1.9.2. I just merged the pull requests as they came, which resulted in several versions of "turn it on," "turn it off," "turn it on"...

Thanks! And seriously, collaborators are most welcome!

jgarber added a commit that referenced this pull request Nov 25, 2011

Merge pull request #11 from purcell/fix-rbconfig-warning
Fix RbConfig / Config warning in Ruby 1.9.3.

@jgarber jgarber merged commit 3242fde into jgarber:master Nov 25, 2011

Owner

jgarber commented Nov 26, 2011

Trying to release... Got a new MacBook Air since the last release of RedCloth, so I have to rebuild my cross-compile tool chain...

Owner

jgarber commented Nov 27, 2011

Okay, I released RedCloth 4.2.9!

Never could get my cross-compile toolchain set up on Lion, so after several hours of trying, I went back to my old MacBook, which of course had somehow rotted w/r/t JRuby. Anyway, I got MRI and JRuby compiled on one computer and the Windows binaries on another, separately pushed to RubyGems.org for a complete release. Can't go on this way much longer! I really need to get the rewrite done, but it's sooo much code...the Textile spec is huge!

Thanks, everyone, for your patches and +1s! I appreciate the encouragement to get it done.

Contributor

purcell commented Nov 27, 2011

Thanks, Jason, on behalf of all the +1 folk. :-)

Yeah, you're the man! Thank you!

trans commented Dec 2, 2011

Appreciating the hard work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment