Promise chainings and Powerstrip #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplification of the processing result
Fix for powerState and powerConsumption implementation
Fix for powerState and powerLoad implementation
|
#16 partially implemented |
|
Nice going, should I merge already or are you working on more improvements? |
|
Thanx, merged. |
|
If there will be another thing I can do, I’ll send another PR. Sorry for my English, hope that the message is clearly understood :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
miIO methods are returning Promises, witch can be nicely handled by capability listeners.
P.S. The
UnhandledPromiseRejectionWarning: Error: invalid_capabilityin stderr is not my bad.