From cd9a45b7167f3f3b20d074c969f8145e457de05f Mon Sep 17 00:00:00 2001 From: Jesse Glick Date: Wed, 25 Oct 2023 19:09:57 -0400 Subject: [PATCH] Warn if `Queue.cancel(Item)` returns `false` --- core/src/main/java/hudson/model/AbstractItem.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/core/src/main/java/hudson/model/AbstractItem.java b/core/src/main/java/hudson/model/AbstractItem.java index 49b1320811c6..35c491bf67d4 100644 --- a/core/src/main/java/hudson/model/AbstractItem.java +++ b/core/src/main/java/hudson/model/AbstractItem.java @@ -730,7 +730,9 @@ public void delete() throws IOException, InterruptedException { Item item = Tasks.getItemOf(i.task); while (item != null) { if (item == this) { - queue.cancel(i); + if (!queue.cancel(i)) { + LOGGER.warning(() -> "failed to cancel " + i); + } break; } if (item.getParent() instanceof Item) {