Skip to content

Jesse Glick jglick

  • Boston
  • Joined on Nov 16, 2009

Organizations

Jenkins CloudBees Stapler Web Framework
April 18, 2014
Jesse Glick
April 18, 2014
jglick commented on commit jenkinsci/jenkins@7c9aab3831
Jesse Glick

This was JENKINS-19418.

April 18, 2014
Jesse Glick

Odd, I would think pathInfo would be mandatory in this context. Bug in the DEV@cloud hosting configuration perhaps?

April 17, 2014
Jesse Glick
  • Jesse Glick 6789567
    Fixing NPE while running a Maven build.
April 17, 2014
Jesse Glick

This can throw NPE. (As FindBugs will warn you.)

April 17, 2014
jglick commented on pull request jenkinsci/jenkins#1194
Jesse Glick

What is the reason for this? Is there some security vulnerability associated with the current behavior? I ask because this change will make interac…

April 16, 2014
Jesse Glick
April 16, 2014
jglick merged pull request jenkinsci/jenkins#1193
Jesse Glick
Update version of bundled Mailer plugin to 1.8 to avoid issues with olde...
1 commit with 3 additions and 1 deletion
April 16, 2014
jglick commented on pull request jenkinsci/jenkins#1161
Jesse Glick

This looks like it would be a major incompatibility. Can @ be left raw? AFAIK it is safe on most filesystems.

April 16, 2014
jglick commented on pull request jenkinsci/jenkins#1161
Jesse Glick

Could actually check for $JENKINS_HOME/users/^john ^smith/config.xml after saving some change such as to the full name.

April 16, 2014
jglick commented on pull request jenkinsci/jenkins#1161
Jesse Glick

Perhaps HudsonPrivateSecurityRealm should use CaseSensitive to begin with? It is not interacting with an external system so there is no reason to c…

April 16, 2014
jglick commented on pull request jenkinsci/jenkins#1161
Jesse Glick

revert

April 16, 2014
jglick commented on pull request jenkinsci/jenkins#1161
Jesse Glick

revert

April 16, 2014
jglick commented on pull request jenkinsci/jenkins#1161
Jesse Glick

What do you mean by Providing this by default ? The default is CASE_INSENSITIVE.

April 16, 2014
jglick commented on pull request jenkinsci/jenkins#1161
Jesse Glick

Are the arguments permitted to be null?

April 16, 2014
jglick commented on pull request jenkinsci/jenkins#1161
Jesse Glick

^ is said to be forbidden on FAT filesystems so this might not be a good choice. Typically _ is used for this purpose.

April 16, 2014
jglick commented on pull request jenkinsci/jenkins#1161
Jesse Glick

(except this default implementation makes sense; just document it)

April 16, 2014
jglick commented on pull request jenkinsci/jenkins#1161
Jesse Glick

I think these methods should just be abstract. It is confusing for the default implementations to be copied from CaseInsensitive.

April 16, 2014
jglick commented on pull request jenkinsci/jenkins#1161
Jesse Glick

revert

April 16, 2014
jglick commented on pull request jenkinsci/jenkins#1161
Jesse Glick

revert

April 16, 2014
jglick commented on pull request jenkinsci/jenkins#1191
Jesse Glick

Changes to fundamental behavior like this this deserves a test. (I created such a test class in #1190, so a bit of a pain to merge, but whatever.) …

April 16, 2014
jglick commented on commit jenkinsci/jenkins@474964cc5a
Jesse Glick

Only provide instances of AuthorizationStrategy that ignore these impliedBy's? Exactly. I think we should not introduce any more permissions gove…

April 16, 2014
jglick closed pull request jenkinsci/winstone#15
Jesse Glick
HttpsConnectorFactory fails to compile with Java 8
April 16, 2014
jglick commented on pull request jenkinsci/winstone#15
Jesse Glick

While it is certainly not a recommended mode for production servers, some people may be using this mode and it is also helpful for testing. Directl…

April 15, 2014
jglick commented on commit jenkinsci/jenkins@474964cc5a
Jesse Glick

a user with this permission […], but without Overall.Administer, is unable to access /pluginManager […] Exactly the idea. CloudBees-hosted server…

April 15, 2014
jglick commented on pull request jenkinsci/jobConfigHistory-plugin#27
Jesse Glick

EphemeralNodes should certainly not be tracked. I am less sure about other AbstractCloudSlaves though. If they are not marked as EphemeralNode then…

April 15, 2014
jglick commented on pull request jenkinsci/jenkins#1190
Jesse Glick

(Of course it is still a bug if something.getNextBuild() returns a deleted build no matter how we got something. I am just not completely sure that…

April 15, 2014
jglick commented on pull request jenkinsci/jenkins#1190
Jesse Glick

Without the fix to dropLinks, this returns b2.

April 15, 2014
jglick commented on pull request jenkinsci/jenkins#1190
Jesse Glick

Is it legitimate to call methods like this on a build after it has been deleted? I cannot find such a call in MavenModuleSetBuild.delete + LogRotat…

April 15, 2014
jglick opened pull request jenkinsci/jenkins#1190
Jesse Glick
[FIXED JENKINS-22395] AbstractProject.getNextBuild returned deleted build
1 commit with 103 additions and 10 deletions
Something went wrong with that request. Please try again.