Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Saving changes should survive an intemediate login #146

Open
jgm opened this Issue Jul 9, 2011 · 3 comments

Comments

Projects
None yet
1 participant
Owner

jgm commented Jul 9, 2011

When saving while the session has expired, the changes will not be saved
after login.  I'd not expect the login form to forget about the changes I
made.  (This is especially annoying since the session times out pretty
fast, too fast for a long editting session at least ;)

Google Code Info:
Issue #: 2
Author: lemps...@gmail.com
Created On: 2008-12-11T09:23:54.000Z
Closed On: 

@ghost ghost assigned jgm Jul 9, 2011

Owner

jgm commented Jul 9, 2011

The problem you encountered is partially fixed in the latest release, 0.3.3.

In the previous version of gitit, the session timer started when the user logged in
and was never reset. In 0.3.3, the session time is reset to one hour every time you
start editing a page. So, unless you spend more than an hour editing a
single page, you will not be logged off unexpectedly.

I think this is enough of a fix for now. I thought a bit about how form data might
be made persistent between sessions, but this would be complex, and I'm not sure the
benefits are worth the cost.

Google Code Info:
Author: fiddloso...@gmail.com
Created On: 2008-12-28T20:34:47.000Z

Owner

jgm commented Jul 9, 2011

You could have some ajax polling every hour or so to maintain the session freshness

Google Code Info:
Author: zimb...@oree.ch
Created On: 2009-01-02T14:06:01.000Z

Owner

jgm commented Jul 9, 2011

A better suggestion, I think, would be the logged-out page could preserve the edited
text; then, when one is logged in and returned to the edit form, the edited text
could replace the editbox's default text.

Google Code Info:
Author: gwe...@gmail.com
Created On: 2009-06-08T21:00:49.000Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment