Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Default CSS hides links in headers #252

Open
jgm opened this Issue Jul 9, 2011 · 2 comments

Comments

Projects
None yet
1 participant
Owner

jgm commented Jul 9, 2011

In the screen.css supplied with gitit, we have:

  h1 > a:link, h1 > a:active, h1 > a:hover, h1 > a:focus, h1 > a:visited,
  h2 > a:link, h2 > a:active, h2 > a:hover, h2 > a:focus, h2 > a:visited,
  h3 > a:link, h3 > a:active, h3 > a:hover, h3 > a:focus, h3 > a:visited,
  h4 > a:link, h4 > a:active, h4 > a:hover, h4 > a:focus, h4 > a:visited,
  h5 > a:link, h5 > a:active, h5 > a:hover, h5 > a:focus, h5 > a:visited,
  h6 > a:link, h6 > a:active, h6 > a:hover, h6 > a:focus, h6 > a:visited {
        color: black; text-decoration: none; }

This has the unfortunate effect of hiding links in headers, and I have problems seeing the rationale behind this.  Personally, I would opt for a conservative default CSS, but instead providing examples for users to copy into their custom.css.

Google Code Info:
Issue #: 109
Author: ketilm...@gmail.com
Created On: 2011-01-15T10:50:19.000Z
Closed On: 

@jgm jgm was assigned Jul 9, 2011

Owner

jgm commented Jul 9, 2011

The rationale is that, when tables of contents are used, every header is a link, and it looks bad to have them all underlined. A better approach would be: put a special class on the anchors in header links to the table of contents:

My header

Then the css could just turn off text decorations for those links, without affecting what happens when you aren't using table of contents.

For now you should be able to override the choices in screen.css using custom.css.

Google Code Info:
Author: fiddloso...@gmail.com
Created On: 2011-01-15T18:06:13.000Z

Owner

jgm commented Jul 9, 2011

Google Code Info:
Author: fiddloso...@gmail.com
Created On: 2011-01-15T18:06:58.000Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment