Links to external sources also sometimes get "Go to wiki page" title/popup #253

Open
jgm opened this Issue Jul 9, 2011 · 3 comments

Projects

None yet

1 participant

@jgm
Owner
jgm commented Jul 9, 2011
Links with the linked location inside the square brackets, followed by empty parentheses will give the link a "Go to wiki page" title attribute, resulting in this text being shown as popup on mouse-over.  Links with the location inside the parentheses do not get this.

So entering a link like

 [http://biohaskell.org/]()

will give a "Go to wiki page" link, while 

 [the applications page](Applications)

will not.

Google Code Info:
Issue #: 110
Author: ketilm...@gmail.com
Created On: 2011-01-16T19:01:46.000Z
Closed On: 
@jgm
Owner
jgm commented Jul 9, 2011

http://biohaskell.org/ is not a correct markdown/gitit way of creating a link to http://biohaskell.org.
The page name syntax is a special gitit syntax for wikilinks only.
If you want to link to an external page, use standard markdown syntax for that:

http://biohaskell.org/

or

the biohaskell page

As you point out, the applications page does not get marked up with that title attribute. That's because it is just straight markdown -- it doesn't go through gitit's special wikipage filter. Maybe it would be better just to get rid of the title attribute throughout?

Google Code Info:
Author: fiddloso...@gmail.com
Created On: 2011-01-16T19:17:37.000Z

@jgm jgm was assigned Jul 9, 2011
@jgm
Owner
jgm commented Jul 9, 2011

OK, thanks for the tip (although the "incorrect" way works, too).

Anyway, losing the "Go to wiki page" text would be no great loss, but as an alternative, it could provide a more informative message, e.g. the actual link
target, whatever's in the parentheses. AFAICT, this would work equally well for
internal and external links, too.

Google Code Info:
Author: ketilm...@gmail.com
Created On: 2011-01-16T19:50:42.000Z

@jgm
Owner
jgm commented Jul 9, 2011

Oh, and I think it makes sense to allow http://... just for consistency, and because this is the obvious way to do it from the help text (left margin when editing).

Google Code Info:
Author: ketilm...@gmail.com
Created On: 2011-01-16T20:44:37.000Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment