Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen interface explanation on help file could be more clear #266

Open
andyring opened this issue Jul 26, 2011 · 1 comment
Open

Listen interface explanation on help file could be more clear #266

andyring opened this issue Jul 26, 2011 · 1 comment

Comments

@andyring
Copy link
Contributor

I think the help text (gitit --help) for the interface option (--
listen=INTERFACE) can be more clear.

Currently the message is "Specify interface to listen on". To me this
means something like "eth0" or "br1", but the code is looking for an
IP address. I would like to suggest the help message text instead
read "Specify IP address to listen on".

I have implemented such here:

https://github.com/andyring/gitit/commit/b2a1300c2ca38bc23144bddc9b45e798e210a1b6

@jgm
Copy link
Owner

jgm commented Jul 27, 2011

That seems fine. Can you generate a pull request from this
commit? Then I can merge it automatically from the github site.

John

+++ andyring [Jul 26 11 16:28 ]:

I think the help text (gitit --help) for the interface option (--
listen=INTERFACE) can be more clear.

Currently the message is "Specify interface to listen on". To me this
means something like "eth0" or "br1", but the code is looking for an
IP address. I would like to suggest the help message text instead
read "Specify IP address to listen on".

I have implemented such here:

https://github.com/andyring/gitit/commit/b2a1300c2ca38bc23144bddc9b45e798e210a1b6

jgm added a commit that referenced this issue Jul 27, 2011
Listen interface explanation on help file could be more clear (#266)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants