Fix wiki links when `base-url` is set to empty and `absolute-urls` to yes #359

merged 1 commit into from Apr 2, 2014


None yet
2 participants

tianyicui commented Apr 7, 2013

In config file, when base-url is set to empty (or /, which will then be trailed to empty) and absolute-urls set to yes, the wiki links doesn't actually use absolute urls, since it will use </> to concat base-url and the wiki link.

So in page /Sub/Page, the link [OtherPage] will produce the code <a href="OtherPage"> thus point to /Sub/OtherPage, while it should produce the code <a href="/OtherPage">.

We should always concat a '/' before the base-url to make sure the produced url is an absolute url.


This comment has been minimized.

Show comment Hide comment

jgm Apr 2, 2014




jgm commented Apr 2, 2014


jgm added a commit that referenced this pull request Apr 2, 2014

Merge pull request #359 from tianyicui/absolute_wiki_links_bug
Fix wiki links when `base-url` is set to empty and `absolute-urls` to yes

@jgm jgm merged commit a7f85e6 into jgm:master Apr 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment