Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression in citeproc: p tags inside divs in HTML output #6966

Closed
jgm opened this issue Dec 20, 2020 · 0 comments
Closed

Fix regression in citeproc: p tags inside divs in HTML output #6966

jgm opened this issue Dec 20, 2020 · 0 comments
Labels
citeproc format:HTML priority:high writer
Milestone
next release

Comments

@jgm
Copy link
Owner

jgm commented Dec 20, 2020

pandoc 2.11.3 adds p elements under the divs for citeproc bib entries:

% ./2.11.3/pandoc-2.11.3/bin/pandoc -C --biblio bib.bib 
@a2
^D
<p><span class="citation" data-cites="a2">Doe (2006)</span></p>
<div id="refs" class="references csl-bib-body hanging-indent" role="doc-bibliography">
<div id="ref-a2" class="csl-entry" role="doc-biblioentry">
<p>Doe, John. 2006. <em>A2</em>. Cambridge: Cambridge University Press.</p>
</div>
</div>

This is a regression caused by 171d3db. Compare:

 % ./2.11.2/pandoc-2.11.2/bin/pandoc -C --biblio bib.bib 
@a2
^D
<p><span class="citation" data-cites="a2">Doe (2006)</span></p>
<div id="refs" class="references csl-bib-body hanging-indent" role="doc-bibliography">
<div id="ref-a2" class="csl-entry" role="doc-biblioentry">
Doe, John. 2006. <em>A2</em>. Cambridge: Cambridge University Press.
</div>
</div>

pandoc-citeproc did not include the p's either.

I think the original behavior is desirable.
@jgm jgm added this to the next release milestone Dec 20, 2020
@jgm jgm closed this as completed in 9cbbf18 Dec 21, 2020
Minoru added a commit to jaspervdj/hakyll that referenced this issue Dec 30, 2020
@Minoru
Revert "Fix golden test failing with pandoc >= 2.11.3 (#829)"
bd0badf 
This reverts commit 87e93c6.

I screwed up with that one: the change in behaviour was a regression[1]
in Pandoc, and I shouldn't have papered over it. It's fairly unlikely
that someone would build Hakyll's test suite with one of the two Pandoc
versions that regressed, so I simply revert my earlier commit.

1. jgm/pandoc#6966
@Minoru Minoru mentioned this issue Dec 30, 2020
Merged
Minoru added a commit to jaspervdj/hakyll that referenced this issue Dec 30, 2020
@Minoru
Revert "Fix golden test failing with pandoc >= 2.11.3 (#829)" (#830)
f388182 
This reverts commit 87e93c6.

I screwed up with that one: the change in behaviour was a regression[1]
in Pandoc, and I shouldn't have papered over it. It's fairly unlikely
that someone would build Hakyll's test suite with one of the two Pandoc
versions that regressed, so I simply revert my earlier commit.

1. jgm/pandoc#6966
duvallj pushed a commit to duvallj/hakyll that referenced this issue Jan 25, 2021
@Minoru @duvallj
Revert "Fix golden test failing with pandoc >= 2.11.3 (jaspervdj#829)" (
459d578 
jaspervdj#830)

This reverts commit 87e93c6.

I screwed up with that one: the change in behaviour was a regression[1]
in Pandoc, and I shouldn't have papered over it. It's fairly unlikely
that someone would build Hakyll's test suite with one of the two Pandoc
versions that regressed, so I simply revert my earlier commit.

1. jgm/pandoc#6966
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
citeproc format:HTML priority:high writer
Projects
None yet
Milestone
next release
Development

No branches or pull requests
1 participant
@jgm