Make #+pandoc-emphasis-pre work as expected (#8059) #8360
Conversation
Since #+pandoc-emphasis-pre and #+pandoc-emphasis-post have somewhat different implementations, it is wise to test them separately (e.g. issue jgm#8059 affects only the pre char setting). The addition of tests for an alphanumeric pre/post char demonstrates the aforementioned issue.
So far, orgStateLastPreCharPos wasn't updated appropriately after each parsing to native Str (by the parser str). In addition to solving this, the guard notAfterString in emphasisStart is removed to allow emphasis after Str at the first place.
With the introduction of the settings for allowed pre/post chars around emphasized text (and the resolve to jgm#8059), such markup-chars may appear in the middle of the word according to the user's choice.
|
By the way, I originally used |
|
Thank you, this is excellent.
The function |
Yes, I see how this expression is useful. Makes it clear that we're here for the side effect. |
|
Thank you! |
|
My pleasure :) |
The main issue with the original implementation is that it kept the assumption that no emphasis markers may occur directly after most non-whitespace chars, e.g. in the middle of the word (in Pandoc terms: following native
Str). But with the possibility to modify which chars are allowed around emphasized text, Pandoc should remain indifferent in that respect.These commits allow it and modify some tests accordingly. This is both:
org-emphasis-regexp-components.Resolves #8059.
Footnotes
which is the case in Hebrew and German, both of which I speak. ↩