Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRST Reader - Improved Role Support #1805
Conversation
bergey
added some commits
Dec 5, 2014
This comment has been minimized.
This comment has been minimized.
This looks promising to me -- let's wait a few days to see if @merijn chimes in. |
This comment has been minimized.
This comment has been minimized.
At a glance it looks fine to me. To be honest, I'm not really sure why |
added a commit
that referenced
this pull request
Dec 15, 2014
jgm
merged commit a864e9a
into
jgm:master
Dec 15, 2014
1 check passed
continuous-integration/travis-ci
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
bergey commentedDec 12, 2014
These changes make Roles behave more like the RST definition, and I hope more useful. I've also added warnings when the RST reader ignores syntax.
Commit e784d4b refactors custom role handling, but shouldn't change behavior (except order of classes). I think it makes the code easier to understand, but feedback is welcome.
@merijn, do you have time to take a look? I think you were the last to work on custom roles. In particular, I've changed the type of
stateRstCustomRoles
. Before my changes, the base role was computed when defining a new custom role, and ignored when rendering the role. I don't see any reason (other than maybe debugging) why we need to store both of these. I also don't see how the parent role could depend on the Attrs. Does this look OK, or am I breaking something?This differs from rst2xml.py in (at least) the following ways, which I'm willing to fix if they bother people. I suspect they're not issues in practice.