New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vimwiki reader #3705

Merged
merged 104 commits into from Jun 19, 2017

Conversation

Projects
None yet
3 participants
@ycpei
Contributor

ycpei commented May 28, 2017

See #863.

This is a preliminary version.

Descriptions and comments about progress etc. are in the issue thread.

@ycpei

This comment has been minimized.

Show comment
Hide comment
@ycpei

ycpei Jun 16, 2017

Contributor

I think this may be ready to merge now. Let me know if there are any bugs or other problems.

Edit: Sigh. Just found another bug. Will fix it soon.

Edit 2: the bug is fixed. Ready to merge again.

Contributor

ycpei commented Jun 16, 2017

I think this may be ready to merge now. Let me know if there are any bugs or other problems.

Edit: Sigh. Just found another bug. Will fix it soon.

Edit 2: the bug is fixed. Ready to merge again.

@jgm

This comment has been minimized.

Show comment
Hide comment
@jgm

jgm Jun 19, 2017

Owner

test/vimwiki-reader.html seems not to be used; can it be removed?

Owner

jgm commented Jun 19, 2017

test/vimwiki-reader.html seems not to be used; can it be removed?

@jgm

This comment has been minimized.

Show comment
Hide comment
@jgm

jgm Jun 19, 2017

Owner

Can you make sure that the code is wrapped to within 80 columns (as requested in CONTRIBUTING.md)?

Owner

jgm commented Jun 19, 2017

Can you make sure that the code is wrapped to within 80 columns (as requested in CONTRIBUTING.md)?

@ycpei

This comment has been minimized.

Show comment
Hide comment
@ycpei

ycpei Jun 19, 2017

Contributor

@jgm test/vimwiki-reader.html was the output of pandoc -f vimwiki -t html -s --css data/vimwiki.css -o vimwiki-reader.html as a test easy for a human eye to see that the html output of the pandoc reader is the same as the vimwiki plugin. It has been removed now.

I have now enforced the 80 column rule.

I also added support for diary links. I only added it now because it relies on configs in the vim plugin of vimwiki. Since there is a default config I'm using that, namely the diary links like [[diary:yyyy-mm-dd]] points to diary/yyyy-mm-dd.html.

Contributor

ycpei commented Jun 19, 2017

@jgm test/vimwiki-reader.html was the output of pandoc -f vimwiki -t html -s --css data/vimwiki.css -o vimwiki-reader.html as a test easy for a human eye to see that the html output of the pandoc reader is the same as the vimwiki plugin. It has been removed now.

I have now enforced the 80 column rule.

I also added support for diary links. I only added it now because it relies on configs in the vim plugin of vimwiki. Since there is a default config I'm using that, namely the diary links like [[diary:yyyy-mm-dd]] points to diary/yyyy-mm-dd.html.

@jgm jgm merged commit 564c779 into jgm:master Jun 19, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jgm

This comment has been minimized.

Show comment
Hide comment
@jgm

jgm Jun 19, 2017

Owner

Thanks very much for this contribution. There may be further problems that appear, but I think this is in good shape to merge.

Owner

jgm commented Jun 19, 2017

Thanks very much for this contribution. There may be further problems that appear, but I think this is in good shape to merge.

@ycpei

This comment has been minimized.

Show comment
Hide comment
@ycpei

ycpei Jun 19, 2017

Contributor

Thanks very much for merging. I'll keep an eye on issues related to this reader. Also feel free to @ me whenever a problem appears.

Contributor

ycpei commented Jun 19, 2017

Thanks very much for merging. I'll keep an eye on issues related to this reader. Also feel free to @ me whenever a problem appears.

@ycpei ycpei deleted the ycpei:vimwiki branch Jun 20, 2017

@ycpei ycpei referenced this pull request Jun 20, 2017

Closed

Abstract syntax tree #314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment