Allow placing custom readers and writers in data subdir #8112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgm
reviewed
Jun 7, 2022
tarleb
force-pushed
the
reader-writer-datadir
branch
from
6bc7791
to
25b66e6
Compare
tarleb
force-pushed
the
reader-writer-datadir
branch
from
25b66e6
to
e47e3c6
Compare
jgm
reviewed
Jun 9, 2022
src/Text/Pandoc/Class/PandocMonad.hs
Outdated
| @@ -668,6 +669,29 @@ withPaths (p:ps) action fp = | |||
| catchError ((p </> fp,) <$> action (p </> fp)) | |||
| (\_ -> withPaths ps action fp) | |||
|
|
|||
| -- | If @fp@ doesn't exist, but the data file relative to @/subdir/@ | |||
| -- does, then return that; otherwise return @fp@. | |||
| findFile :: PandocMonad m | |||
There was a problem hiding this comment.
Sorry to revise my original suggestion, but what about findFileWithDataFallback?
findFile should be reserved for something less special-purpose.
There was a problem hiding this comment.
Also, could we use this function to simplify readMetadataFile?
tarleb
force-pushed
the
reader-writer-datadir
branch
from
e47e3c6
to
2f87d25
Compare
tarleb
force-pushed
the
reader-writer-datadir
branch
from
2f87d25
to
128b95d
Compare
jgm
reviewed
Jun 9, 2022
tarleb
force-pushed
the
reader-writer-datadir
branch
from
128b95d
to
55ae676
Compare
|
This looks good to go. |
jgm
added a commit
that referenced
this pull request
Jun 10, 2022
be sought in the readers/writers subdirectory of the user data directory if not found relative to the working directory. Documents #8112.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.