Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add some helpful functionality #19

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

aidanlister commented May 28, 2011

I switched one of my applications to fandjango today, and these were the three things I missed most:

a) Template tags to make all the init magic easier
b) Having request.facebook.graph set so I can use it quickly
c) Being able to debug while offline

Thanks for your consideration.

Owner

jgorset commented May 28, 2011

Thanks so much, Aidan. This is awesome.

I hope you don't mind that I...

  • ... didn't pull 0d484ec (see 932806).
  • ... integrated FacebookGraphMiddleware into FacebookMiddleware. I'd like to facilitate for facebook-sdk in this way, too.
  • ... didn't pull FacebookDebugCanvasMiddleware, because this can already be accomplished by attaching the signed request to the query string. I should really document that feature.

🍰

Owner

jgorset commented May 28, 2011

Pull complete!

@jgorset jgorset closed this May 28, 2011

Contributor

aidanlister commented May 28, 2011

Awesome! Here's some documentation for the template tags:

aidanlister/fandjango@47628ed

I'm not sure how to roll that single commit into a pull request.

Owner

jgorset commented May 28, 2011

Thanks!

I'm not sure that we need separate template tags to load and initialize
the JavaScript SDK, though... can't facebook_init do both of these things?

Contributor

aidanlister commented May 28, 2011

I guess they could be combined, or a single tag provided to do both ... I'm trying to imagine a situation where you'd want one without the other, but I can't think of anything.

Owner

jgorset commented May 28, 2011

I couldn't think of one, either: #1983e5. ;-)

Contributor

aidanlister commented May 29, 2011

Good morning :)

a) So I've done a fresh pull from your repository, but I had to reapply #0d484ec. Using the ./mange.py runserver without #0d484ec I get the following: http://dpaste.com/547917/

b) Do you want me to rewrite the docs for #1983e5 or did you forget to merge them?

Owner

jgorset commented May 29, 2011

Good morning!

a) So I've done a fresh pull from your repository, but I had to reapply #0d484ec. Using the ./mange.py runserver without #0d484ec I get the following: http://dpaste.com/547917/

The facebook_authorization_required decorator takes an optional argument, so you'll have to call the function even if you don't provide it.

@facebook_authorization_required(redirect_uri='http://example.org)
def view(request):
    pass

@facebook_authorization_required()
def view(request):
    pass

b) Do you want me to rewrite the docs for #1983e5 or did you forget to merge them?

I just rewrote the documentation to reflect the changes we made last night.

Contributor

aidanlister commented May 29, 2011

Hooray!

Owner

jgorset commented May 29, 2011

What do you say we start thinking about the next major version and facilitating for Facebook Connect? I've created an aptly-named branch for the occasion.

Contributor

aidanlister commented May 29, 2011

Sounds good! Would you be open to moving to fandjango into the "pythonforfacebook" organisation and creating the one-true-library to rule them all?

I've got 41 followers here, https://github.com/aidanlister/django-facebook
4 here, https://github.com/pythonforfacebook/django-facebook
and 146 here, https://github.com/tschellenbach/Django-facebook

I'd really like to get everyone on the same package. I think we should keep the fandjango name, it's catchier.

Owner

jgorset commented May 29, 2011

Sounds good! Would you be open to moving to fandjango into the "pythonforfacebook" organisation and creating the one-true-library to rule them all? [...] I'd really like to get everyone on the same package

I'm not opposed to the idea, though I'm a little surprised that you're ready to abandon django-facebook for this library... do the other members of the team share your sentiments?

Contributor

aidanlister commented May 29, 2011

Yep, everyone has agreed that we need to pool our efforts to create a single SDK & a single Django package. This was born out of the frustration of over a dozen pull requests sitting unanswered for the official SDK.

tschellenbach's agreed, but he will continue maintaining Django-facebook at his end as well.

I'm happy to give up the django-facebook name - it's less catchy and I'm a little worried about getting sued for using "facebook" in the name (like Drupal for Facebook was). I like Fandjango's approach, it's nice and clean and serves as a good base for going forward.

Owner

jgorset commented May 29, 2011

I certainly share your enthusiasm for "fandjango", but I think we might benefit from proceeding under a different name altogether. I think Fandjango is in a good place right now, and so I'd be happy to retire it to the Facebook Canvas-exclusive library it originally set out to be and join you in developing a library that can do both and more.

I propose we baptize a new library founded on the codebase of the facebook-connect branch. I don't know what we'd call it, but let's try to avoid a lawsuit.

Contributor

aidanlister commented May 29, 2011

Yeap that sounds great, let's get started!

djangobook? :)

Owner

jgorset commented May 29, 2011

I'll get right to it.

I'm very suprised to read about your plans and very excited to see where this projects is heading to.
I don't want to spoil anything, you may just want to reconsider the name beacuse of http://www.djangobook.com/

Owner

jgorset commented May 30, 2011

@Tini,

thanks for the heads-up! :-)

@aidanlister,

I've created a repository for the new library, but tini makes a good case for reconsidering its name.

I really like the idea of gathering all the forces together. Maybe you can get the guys from https://github.com/cartwheelweb/django-la-facebook on board?

Contributor

aidanlister commented May 30, 2011

Thanks for the extra link tini, I've emailed them (info@cartwheelweb.com).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment