Sandstorm: Properly support gzipped assets. #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidjgraph I've tested this locally and everything works. Should be ready to build and publish. |
This reverts my previous approach and applies a better approach. My previous approach expected URLs to change to have ".gz" extensions. The new approach keeps the URLs the same but checks if a file exists on-disk that has the same name with the ".gz" extension.
|
I updated the build instructions to exactly those I tried at https://github.com/jgraph/draw.io/tree/master/etc/sandstorm. Or you maybe using clang/not latest capnp/other? |
|
@davidjgraph Sorry, what is the issue you're running into exactly? |
davidjgraph
added a commit
that referenced
this pull request
Aug 7, 2019
Sandstorm: Properly support gzipped assets. Former-commit-id: c4b2403
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts my previous approach and applies a better approach.
My previous approach expected URLs to change to have ".gz" extensions. The new approach keeps the URLs the same but checks if a file exists on-disk that has the same name with the ".gz" extension.
Fixes sandstorm-io/sandstorm#2641