Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HttpClient 4.3.x, Removing Deprecated HttpClient methods and classes #21

Closed
phasebash opened this issue Jan 27, 2014 · 12 comments
Closed

Comments

@phasebash
Copy link

@phasebash phasebash commented Jan 27, 2014

This request is to update httpbuilder to use the most recent HttpClient APIs. Notable changes include the removal of HttpParams as a way of configuring settings (this is now RequestConfig), removing deprecated interfaces and abstract/concrete classes (HttpClient, DefaultHttpClient, AbstractHttpClient), and making sure httpbuilder uses non-deprecated CloseableHttpClient methods.

@phasebash
Copy link
Author

@phasebash phasebash commented Jan 28, 2014

I can pass you a patch, but a word of warning, the new 4.3.1 HttpClients are immutable, which is a change we cannot hide within the HTTPBuilder API, so there will be noticeable changes to the external API. I'll pass it your way for your consideration, feel free to change as you see fit.

In the least if a client can provide the CloseableHttpClient they want to use in HTTPBuilder, this will go a long way.

@jgritman
Copy link
Owner

@jgritman jgritman commented Jan 28, 2014

Sounds good. Getting ready to release version 0.7 right now, but if the pull request looks good, we can push it out as 0.8.

@phasebash
Copy link
Author

@phasebash phasebash commented Jan 29, 2014

Great! What's your target release date for 0.8?

@jgritman
Copy link
Owner

@jgritman jgritman commented Feb 5, 2014

Version 0.7 was released today, but I don't have a target date for 0.8. Once your patch is ready, I can probably push it out within a week or two.

@phasebash
Copy link
Author

@phasebash phasebash commented Feb 15, 2014

I'm sorry to say, for our small uses of HTTPBuilder, we ended up migrating fluent-hc, hence the long delay. After the smoke clears with some other work/life obligations I'll try and come back around and finish this off.

@jgritman
Copy link
Owner

@jgritman jgritman commented Feb 25, 2014

If you publish the work you've started I can looking into finishing the job. I'd like to get this into 0.8 myself, rather than let the version of HttpClient fall behind any further. Do you have a sense of how much effort is left?

@gregorydickson
Copy link

@gregorydickson gregorydickson commented Sep 17, 2014

+1 this!!

@Pyrolistical
Copy link

@Pyrolistical Pyrolistical commented Nov 20, 2014

👍

@gesellix
Copy link

@gesellix gesellix commented Nov 20, 2014

@phasebash @jgritman any progress on this?

@phasebash
Copy link
Author

@phasebash phasebash commented Nov 23, 2014

I dropped this work and haven't been back to it since. Sorry!

@juwi
Copy link

@juwi juwi commented Jul 27, 2015

+1
HttpClient > 4.3.2 would also bring SNI support which would make the Library much more useful in Loadbalanced environments. Can't really encourage ignoreSSLIssues() as a workaround.

@gregorydickson
Copy link

@gregorydickson gregorydickson commented May 9, 2016

I just forked to http://github.com/gregorydickson/httpbuilder and I am going to try and do this upgrade

@phasebash phasebash closed this Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants