Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image in modal has white space below if used with content next to it #3587

Open
andreobriennz opened this issue Nov 6, 2022 · 0 comments
Open

Comments

@andreobriennz
Copy link

andreobriennz commented Nov 6, 2022

This is about the Bulma CSS framework
I'm using Bulma 0.9.4, but have also noticed this in other versions over the past 2-3 years.
My browsers Firefox and Chrome (Macbook Pro 13").
I've noticed is multiple Sass versions.
I have checked this is not a duplicate.

Description

When using a modal with an image on the left and text on the right there is always white space below the image, even if there is very little text next to it.

Steps to Reproduce

Add the following code to any project (replacing src="..." with an actual image URL):

        <div class="modal is-active" >
            <div class="modal-background"></div>

            <div class="modal-content">
                <div class="modal-image">
                    <img src="..." />
                </div>
                <div class="modal-text">
                    <h2>Some Heading</h2>
                    <div>Text</div>
                </div>
            </div>
        </div>

Expected behavior

The modal appears with no white space below the image.

Actual behavior

There is always about 5px of white space below the image.

It can be fixed with the following code but I wonder if it would be better for this to be fixed in the Bulma framework?

    .modal-image {
        overflow: hidden;
        img {
            height: 100%;
        }
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant