jhargis

  • Portland, OR
  • Joined on
@jhargis
  • @jhargis 245b243
    typo: milliseconds, not seconds
jhargis commented on pull request ksylvest/jquery-growl#28
@jhargis

ugh.. not quite right. fixing

jhargis opened pull request ksylvest/jquery-growl#28
@jhargis
Explicit deprecation warning and README addition
2 commits with 2 additions and 1 deletion
@jhargis
  • @jhargis 8cb39b9
    added available duration option to README
@jhargis
  • @jhargis ab60b9a
    More explicit deprecation warning
jhargis commented on issue ksylvest/jquery-growl#26
@jhargis

So responsive! thank you! great plugin Kevin!

jhargis commented on issue ksylvest/jquery-growl#26
@jhargis

reviewed

jhargis commented on pull request ksylvest/jquery-growl#27
@jhargis

aside from the typo :+1: :shipit:

jhargis commented on pull request ksylvest/jquery-growl#27
@jhargis

/s/DEPRECIATION/DEPRECATION/

jhargis commented on issue ksylvest/jquery-growl#26
@jhargis

I like them both! Fixed slightly better just because it's shorter. I'd suggest doing something like leaving static in and throwing a deprecation wa…

@jhargis
option name `static` is js reserved keyword