Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Improve cursor logic, emoji handling, canonicality, and tests #4
This PR makes the following changes:
jhchen left a comment
I'd slightly prefer if we can call it newRange/oldRange instead of newSelection/oldSelection since it's shorter and in Quill selection is mostly related to the module and range is object representing position info.
Also we could just change all usage of == into === to keep things consistent, with the exception of an intentional comparison with null/undefined.
Otherwise looks good and happy to have this edge case taken care of!