Ensure that anonymous branches result in well-formed names #52

Closed
jhclark opened this Issue May 16, 2012 · 4 comments

Projects

None yet

2 participants

Owner
jhclark commented May 16, 2012

As of commit e976e9e, I introduced a bug in which anonymous branch points receive names from raw values. I'd like to fail if those values don't conform to the rules of branch names. What's the easiest way of doing this?

See branchAssignment in Grammar.scala

@dowobeha dowobeha was assigned May 16, 2012
Collaborator

So you want branch names to conform to bash variable name requirements?

Owner
jhclark commented May 16, 2012

If that's the current restriction on branch names, it could actually be
relaxed a bit.

For example, having dots (as will be common with real numbers) should be
allowed.

Having dashes, commas, exclamation points, and other such nonsense that
doesn't belong in directory names should be prohibited though.

On Wed, May 16, 2012 at 1:01 PM, Lane Schwartz <
reply@reply.github.com

wrote:

So you want branch names to conform to bash variable name requirements?


Reply to this email directly or view it on GitHub:
#52 (comment)

Collaborator

Where should this be enforced? In grammar.scala or on your end?

Owner
jhclark commented May 16, 2012

Seems like the grammar would be the easiest place, but if it's not, then
WorkflowChecker.scala is my 2nd pass catch-all.

On Wed, May 16, 2012 at 2:25 PM, Lane Schwartz <
reply@reply.github.com

wrote:

Where should this be enforced? In grammar.scala or on your end?


Reply to this email directly or view it on GitHub:
#52 (comment)

@dowobeha dowobeha added a commit that closed this issue Jun 26, 2012
@dowobeha dowobeha Verify that branch names are valid (fixes #52)
when the branch name was obtained automatically
from an anonymous branch assignment.
1940162
@dowobeha dowobeha closed this in 1940162 Jun 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment