Cleanup #1

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

rail commented May 10, 2012

Mostly it's just a clean up.

There are 2 major things:

  • opening files using 'rb' to calculate their digest
  • using None instead of [] in Manifest.init
Owner

jhford commented May 10, 2012

I merged the majority of the changes. Some of the changes that I didn't merge weren't merged because tests didn't pass with them.

I'll figure out which changes are specifically breaking them.

Contributor

rail commented May 11, 2012

Hmm, that's interesting. The patched version passed test on my machine (python 2.7). Anyway, thanks a lot!

@rail rail closed this May 11, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment