Export types from package.json #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See [TypeScript #52363](microsoft/TypeScript#52363) for further information Importing mergician without types exported results in the following error when TypeScript `moduleResolution` config is set to `Bundler`: `Could not find a declaration file for module 'mergician'. '/node_modules/mergician/dist/mergician.esm.js' implicitly has an 'any' type. There are types at '/node_modules/mergician/dist/mergician.d.ts', but this result could not be resolved when respecting package.json "exports". The 'mergician' library may need to update its package.json or typings.`
jhildenbiddle
requested changes
Feb 13, 2024
There was a problem hiding this comment.
Thanks for this, @boylett.
If we add export.types I assume we can remove the top-level types property found above the exports property?
|
To ensure minimal breakage, I'd leave the top-level |
|
Thanks, @boylett! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See TypeScript #52363 for further information
Importing mergician without types exported results in the following error when TypeScript
moduleResolutionconfig is set toBundler: