Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't find needle code for 'jhipster-needle-add-admin-route' #11285

Closed
WiteCastle opened this issue Feb 11, 2020 · 4 comments · Fixed by #11289
Closed

Can't find needle code for 'jhipster-needle-add-admin-route' #11285

WiteCastle opened this issue Feb 11, 2020 · 4 comments · Fixed by #11289

Comments

@WiteCastle
Copy link

@WiteCastle WiteCastle commented Feb 11, 2020

Overview of the issue

I'm attempting to update the elasticsearch-reindexer module to the latest Jhipster version but I can't find the function that'll update the jhipster-needle-add-admin-route section. Has this functionality been removed? I don't see any code to edit that needle in the Angular client api:

addToAdminModule(appName, adminAngularName, adminFolderName, adminFileName, enableTranslation, clientFramework) {
const adminModulePath = `${CLIENT_MAIN_SRC_DIR}app/admin/admin-routing.module.ts`;
const importNeedle = 'jhipster-needle-add-admin-module-import';
const moduleNeedle = 'jhipster-needle-add-admin-module';

Motivation for or Use Case

A route should be added to the admin-routing.module.ts file.

Reproduce the error
  1. Create a new jhipster module
  2. Attempt to add a new admin menu item
  3. You'll notice that a new menu item is added to the admin menu but when clicked the page does not exist.
Related issues

Possibly #10443

Suggest a Fix

Add code to the angular needle client that adds back the ability to edit the admin-route needle.

JHipster configuration
JHipster Version(s)
generator-jhipster-elasticsearch-reindexer@1.2.1 D:\Ebsan\workspace\generator-jhipster-elasticsearch-reindexer
`-- generator-jhipster@6.7.0

cat: no such file or directory: .yo-rc.json

JHipster configuration, a .yo-rc.json file generated in the root folder
.yo-rc.json file

JDL for the Entity configuration(s) entityName.json files generated in the .jhipster directory
JDL entity definitions

Environment and Tools

java version "1.8.0_241"
Java(TM) SE Runtime Environment (build 1.8.0_241-b07)
Java HotSpot(TM) 64-Bit Server VM (build 25.241-b07, mixed mode)

git version 2.24.1.windows.2

node: v12.13.0

npm: 6.13.7

yeoman: 3.1.1

Browsers and Operating System

Windows 10, all browsers

  • Checking this box is mandatory (this is just to show you read everything)
@mshima

This comment has been minimized.

Copy link
Member

@mshima mshima commented Feb 11, 2020

What was the original jhipster version?
I can be wrong but, the needle was there, but the api was never added.

@WiteCastle

This comment has been minimized.

Copy link
Author

@WiteCastle WiteCastle commented Feb 11, 2020

The original module was using Jhipster version 6.3.1.

The original module is here: https://github.com/geraldhumphries/generator-jhipster-elasticsearch-reindexer

@mshima

This comment has been minimized.

Copy link
Member

@mshima mshima commented Feb 11, 2020

Just looked at jhipster 6.3.1 code, jhipster-needle-add-admin-route was never used.

I proposed #10286 that used it.
But I closed it as I didn't had the time to work on it.

@kaidohallik

This comment has been minimized.

Copy link
Contributor

@kaidohallik kaidohallik commented Feb 12, 2020

I opened #11289 to add this missing function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.