Angular 2 test cases #4301

deepu105 · 2016-10-10T07:26:42Z

deepu105 · 2016-12-30T09:21:44Z

@jhipster/developers @flaviencathala @VictorADS could you guys try to test any combinations from these and mark them done if they pass please?

VictorADS · 2016-12-30T16:23:55Z

xetys · 2017-01-02T18:15:05Z

I am currently testing the default options with SASS enabled. I know SASS is not our main focus, but it is not really working, as:

hot reload is working somekind strange, not for all files
you can change the main.scss, but it doesn't affect the main.css

so

didn't work

Default with SASS

jdubois · 2017-01-10T10:36:52Z

You also need to test entities with Elasticsearch, with and without i18n at least.

deepu105 · 2017-01-20T22:50:30Z

Test cases reset as we switched to Ng2 router :(

pascalgrimaud · 2017-01-23T09:05:34Z

Some issues I found this morning:

maven build in dev:
- invoke the run webpack:build:dev : discussion with @deepu105 here 88ba738#commitcomment-20570911
pagination
- in user management page, the pagination doesn't work
- when generate an ng2 project (with BankAccount, Operation and Label as entities), the Label page can't be displayed, because of that code: ?page&sort&search
- so I did the same in user-management page and I delete the ?page&sort&search, the page is displayed correctly (as in user management), but the pagination won't work

deepu105 · 2017-01-24T21:59:54Z

@jhipster/developers guys more hands here please. Plz tick off the options that works without any issues (except known issues if any) If there are issues and if you cant do PR then plz open a ticket so that me or someone else can try to fix it

pascalgrimaud · 2017-01-26T06:59:20Z

Here all Travis builds with only ng2 app:
https://travis-ci.org/pascalgrimaud/generator-jhipster/builds/195433340

It seems to be an issue with elasticsearch which should be fixed in this PR #4970

It wont replace manually tests but I think it can help

deepu105 · 2017-01-26T07:16:05Z

Can you also try to enable protractor and Karma tests on all options? Thanks & regards, Deepu

…

On 26 Jan 2017 7:59 a.m., "Pascal Grimaud" ***@***.***> wrote: Here all Travis builds with only ng2 app: https://travis-ci.org/pascalgrimaud/generator-jhipster/builds/195433340 It seems to be an issue with elasticsearch which should be fixed in this PR #4970 <#4970> It wont replace manually tests but I think it can help — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4301 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABDlF4-TMXCqKLHRPUWooXHxSlighgPeks5rWERLgaJpZM4KSSQr> .

pascalgrimaud · 2017-01-26T07:22:40Z

Karma tests are already enabled for all options.
And for protractor, yes I can! I will do that

pascalgrimaud · 2017-01-26T13:13:58Z

With protractor enabled for all builds: https://travis-ci.org/pascalgrimaud/generator-jhipster/builds/195487021

Cassandra + ng2: fail on protractor tests
OAuth2 + ng2: fail on protractor tests

deepu105 · 2017-01-26T17:55:48Z

Thanks @pascalgrimaud I was wondering if we could test most of the options here with some kind of automation. with some script or something that can iterate through options and generate apps according to the options and build, lint, test. we cover some cases in travis but it might be nice to have such a script so that we can test everything locally (or in docker or something)

pascalgrimaud · 2017-01-26T17:59:18Z

@deepu105 : what do you think about using the Travis builds from hipster labs orga ? As it is free and not used as often as jhipster orga

deepu105 · 2017-01-26T17:59:43Z

Yes we can use that if thats possible

deepu105 · 2017-01-26T18:00:37Z

also how difficult it is to configure Travis to run protractor tests on all builds when something is merged to master but not for PR builds?

pascalgrimaud · 2017-01-26T18:01:04Z

Ok I ll give a try. Maybe I will need you to connect the repo to Travis, so I will ping you :P

pascalgrimaud · 2017-01-26T18:04:15Z

Not difficult, just a variable to detect the branch which is currently tested by Travis.
So we can have a better build when merging into master, and a lighter build for PR. Or the other side if you prefer

jdubois · 2017-01-28T22:55:12Z

Social login doesn't work, both with AngularJS 1 and Angular 2
- With Angular 2, the login looks to work, but there is a stacktrace showing a registration email being sent (which shouldn't happen as we use Social login), and then we get redirected to a page with no view (there's the menu and footer, but nothing in the middle)
- With AngularJS 1 I can't get authenticated by Google (and I'm using the same codes as for Angular 2)
On all projects, when I do a "prod" build, I still have a banner (the "ribbon" that shows we are in dev mode), with a message "no translation"
With JWT, I can't test with Swagger: when I click on "try it out" to test an API, it is not authenticated as the JWT token isn't sent. This needs to be checked also for OAuth2

jdubois · 2017-01-28T23:51:27Z

I can't login with UAA. Everything starts up correctly, but the login form gets a 404 error. @xetys if you have time to check...

jdubois · 2017-01-29T00:05:05Z

Websocket is checked as it works in "prod" mode, but in "dev" mode there is no way to use it correctly: with just HMR (port 9060) or with BrowserSync + HMR (port 9000) the socket can't be opened, so it's impossible to develop easily.

ruddell · 2017-01-29T00:11:55Z

@jdubois I didn't have any issues with NG1 and Google, is there a specific error message? Also we send an email on account creation for social users

For NG2, social-auth.register.ts doesn't get the provider/success params from the route. I don't think this.provider = params['provider{success:boolean}']; looks right so I'll leave that to someone who knows ngRouter. For easier testing, the URL that breaks is http://localhost:9000/#/social-register/twitter?success=true

jdubois · 2017-01-29T07:47:21Z

@ruddell for Social login + NG1, I get:

The redirect URI in the request, http://localhost:8080/signin/google, does not match the ones authorized for the OAuth client

But this URL is correctly configured, and works with NG2 (with NG2 it fails after that, when displaying the page)

jdubois · 2017-01-29T07:59:17Z

And the last bullet point "add new languages to app" doesn't work...

-> I'm going to finish testing all those, and then I'll close this ticket and create one specific ticket per issue, as there are just too many of them here

jdubois · 2017-01-29T08:54:47Z

Testing the entities:

Dates cannot be edited (both LocalDate and ZoneDateTime)
ZoneDateTime do not have the correct pop up, as the time can't be set up
The "pager" and "pagination" are the same component
In many-to-many relationships, when you view the entity, you cannot click on the "many" entities

deepu105 · 2017-01-29T10:13:55Z

@jdubois I see the Oauth option is checked but what about #4982 can someone take a look at it? I'm not an Oauth expert

jdubois · 2017-01-29T12:31:38Z

@deepu105 oh I didn't test this, so OK let's uncheck this.
Maybe we should remove the OAuth2 option, it doesn't make much sense (you'd better have an external OAuth2 server, for what we do here JWT is much better and probably more secure), causes lots of issues, and nearly nobody uses it (only 13 generations last month!!). I'll do a ticket for this too.

jdubois · 2017-01-29T12:50:31Z

I've tested everything, I'm going to:

Create tickets for each issue
Give them priorities

If we can't solve them easily, we can still remove options in the generators.

And I'll close this ticket afterwards as it is becoming too big.

deepu105 · 2017-01-29T13:18:10Z

@jdubois IMO lets not remove options as we are only releasing a Beta of angular support and not final. if we remove options we wont get feedback for those as failing options would prompt more contribution from people who try to use them and we can fix them once we move NG2 support out of Beta

jdubois · 2017-01-29T13:19:32Z

@deepu105 it's not really cool to allow options that we know are failing. We should at the very least put a clear warning, like "unfinished".

jdubois · 2017-01-29T13:19:53Z

@deepu105 I'm listing all those errors, I still have good hope we can solve them all.

deepu105 · 2017-01-29T13:22:36Z

Agree but isnt marking something as [BETA] clear warning that its unfinished?
Else we can mark such options [Unstable] so that people still get a chance to use them and fix them if its required for them. if we dont give people a way to use them at all then the burden of fixing those options will be solely on us.

jdubois · 2017-01-29T13:56:26Z

Closing as I added all the issues as specific tickets!

deepu105 · 2017-01-29T17:13:11Z

Did anyone test out an option with a custom jhiPrefix added? Thanks & Regards, Deepu

…

On Sun, Jan 29, 2017 at 2:56 PM, Julien Dubois ***@***.***> wrote: Closed #4301 <#4301>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4301 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABDlF_ZxNs_8gLSEHN14fZsuC5lShgd0ks5rXJqNgaJpZM4KSSQr> .

gmarziou · 2017-01-29T19:34:12Z

Just tried and it does not work.
I used prefix="example".
Should prefix also be used for ***Translate directives?

Template parse errors:↵Can't bind to 'predicate' s…iTranslate="global.fie"): UserMgmtComponent@11:78"} Error: Template parse errors:
Can't bind to 'predicate' since it isn't a known property of 'tr'. ("
        <table class="table table-striped">
            <thead>
            <tr exampleSort [ERROR ->][(predicate)]="predicate" [(ascending)]="reverse" [callback]="transition.bind(this)">
            <th"): UserMgmtComponent@11:28
Can't bind to 'ascending' since it isn't a known property of 'tr'. ("ss="table table-striped">
            <thead>
            <tr exampleSort [(predicate)]="predicate" [ERROR ->][(ascending)]="reverse" [callback]="transition.bind(this)">
            <th exampleSortBy="id"><span "): UserMgmtComponent@11:54
Can't bind to 'callback' since it isn't a known property of 'tr'. (">
            <thead>
            <tr exampleSort [(predicate)]="predicate" [(ascending)]="reverse" [ERROR ->][callback]="transition.bind(this)">
            <th exampleSortBy="id"><span jhiTranslate="global.fie"): UserMgmtComponent@11:78

deepu105 · 2017-01-29T19:55:44Z

Ya I tried as well and fixed most of the issues

deepu105 added the ng2 label Oct 10, 2016

deepu105 added this to the Future 4.0 milestone Oct 10, 2016

deepu105 added the needs-help label Oct 12, 2016

deepu105 mentioned this issue Nov 25, 2016

Angular 2 release plan #4549

Closed

19 tasks

deepu105 modified the milestone: Future 4.0 Nov 25, 2016

deepu105 added ng2 and removed ng2 labels Nov 30, 2016

jdubois mentioned this issue Jan 14, 2017

Missing file with angular 2 and social #4862

Closed

deepu105 mentioned this issue Jan 20, 2017

Adds Ng2-Router ( angular ) #4846

Merged

5 tasks

pascalgrimaud mentioned this issue Jan 23, 2017

ng2: fix route path with pagination #4935

Merged

This was referenced Jan 29, 2017

Social login doesn't work #5002

Closed

JWT doesn't work with Swagger "try it out" #5003

Closed

jdubois mentioned this issue Jan 29, 2017

Prod profile errors #5004

Closed

jdubois mentioned this issue Jan 29, 2017

"dev" mode with Websocket isn't user-friendly #5005

Closed

jdubois added the theme: angular label Jan 29, 2017

This was referenced Jan 29, 2017

LocalDate and ZonedDateTime do not work properly #5006

Closed

"Pager" is not implemented #5007

Closed

Many-to-many relationships links do not work #5008

Closed

Language sub-generator does not work #5009

Closed

jdubois closed this as completed Jan 29, 2017

deepu105 moved this from IN PROGRESS ISSUES to CLOSED ISSUES in Angular 2 Migration Feb 1, 2017

deepu105 mentioned this issue Feb 19, 2017

Angular 2 TODO for next #4794

Closed

21 tasks

Angular 2 test cases #4301

Angular 2 test cases #4301

Comments

deepu105 commented Oct 10, 2016 • edited by jdubois

deepu105 commented Dec 30, 2016

VictorADS commented Dec 30, 2016 • edited by wmarques

xetys commented Jan 2, 2017 • edited

jdubois commented Jan 10, 2017

deepu105 commented Jan 20, 2017

pascalgrimaud commented Jan 23, 2017

deepu105 commented Jan 24, 2017 • edited

pascalgrimaud commented Jan 26, 2017

deepu105 commented Jan 26, 2017 via email

pascalgrimaud commented Jan 26, 2017

pascalgrimaud commented Jan 26, 2017

deepu105 commented Jan 26, 2017

pascalgrimaud commented Jan 26, 2017

deepu105 commented Jan 26, 2017

deepu105 commented Jan 26, 2017

pascalgrimaud commented Jan 26, 2017

pascalgrimaud commented Jan 26, 2017

jdubois commented Jan 28, 2017

jdubois commented Jan 28, 2017

jdubois commented Jan 29, 2017

ruddell commented Jan 29, 2017

jdubois commented Jan 29, 2017

jdubois commented Jan 29, 2017

jdubois commented Jan 29, 2017

deepu105 commented Jan 29, 2017

jdubois commented Jan 29, 2017

jdubois commented Jan 29, 2017

deepu105 commented Jan 29, 2017

jdubois commented Jan 29, 2017

jdubois commented Jan 29, 2017

deepu105 commented Jan 29, 2017

jdubois commented Jan 29, 2017

deepu105 commented Jan 29, 2017 via email

gmarziou commented Jan 29, 2017 • edited

deepu105 commented Jan 29, 2017

deepu105 commented Oct 10, 2016 •

edited by jdubois

VictorADS commented Dec 30, 2016 •

edited by wmarques

xetys commented Jan 2, 2017 •

edited

deepu105 commented Jan 24, 2017 •

edited

gmarziou commented Jan 29, 2017 •

edited