New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds failed for Gradle: missing jhipster-dependencies 2.0.18 #8186

Closed
pascalgrimaud opened this Issue Aug 30, 2018 · 12 comments

Comments

Projects
None yet
3 participants
@pascalgrimaud
Member

pascalgrimaud commented Aug 30, 2018

There was a release of jhipster/jhipster v2.0.18 yesterday, 16 hours ago.

That's why all builds failed with Gradle.

@jdubois : I ping you as you are the only one who can fix it. Maybe just wait more than 24 hours ?

@jdubois

This comment has been minimized.

Show comment
Hide comment
@jdubois

jdubois Aug 30, 2018

Member

Thanks @pascalgrimaud - yes I know about this, I was waiting a few hours to test again. We can't do much more anyway!

Member

jdubois commented Aug 30, 2018

Thanks @pascalgrimaud - yes I know about this, I was waiting a few hours to test again. We can't do much more anyway!

@pascalgrimaud

This comment has been minimized.

Show comment
Hide comment
@pascalgrimaud

pascalgrimaud Aug 30, 2018

Member

Just to let you know, it's the same issue for 0.1.14 too

Member

pascalgrimaud commented Aug 30, 2018

Just to let you know, it's the same issue for 0.1.14 too

@jdubois

This comment has been minimized.

Show comment
Hide comment
@jdubois

jdubois Aug 30, 2018

Member

Oh, and I see 0.1.14 never made it!! That's very bad from JCenter, as it means its sync system is just broken!!!
I'll release a 2.0.19, that's the only way I know to force this.

Member

jdubois commented Aug 30, 2018

Oh, and I see 0.1.14 never made it!! That's very bad from JCenter, as it means its sync system is just broken!!!
I'll release a 2.0.19, that's the only way I know to force this.

jdubois added a commit to jhipster/jhipster that referenced this issue Aug 30, 2018

@jdubois

This comment has been minimized.

Show comment
Hide comment
@jdubois

jdubois Aug 30, 2018

Member

Looks like 2.0.19 is also not sync'ing to JCentral... I'm trying to contact them on Twitter

Member

jdubois commented Aug 30, 2018

Looks like 2.0.19 is also not sync'ing to JCentral... I'm trying to contact them on Twitter

jdubois added a commit that referenced this issue Aug 30, 2018

@jdubois

This comment has been minimized.

Show comment
Hide comment
@jdubois

jdubois Aug 30, 2018

Member

I'm really not good at using Gradle, so please @atomfrede correct me if I'm wrong, but can't we use mavenCentral() to get the artifacts from Maven Central instead or Bintray? That would solve that issue, and would also be better for our stats (as I get the stats from Maven Central on our number of downloads)

Member

jdubois commented Aug 30, 2018

I'm really not good at using Gradle, so please @atomfrede correct me if I'm wrong, but can't we use mavenCentral() to get the artifacts from Maven Central instead or Bintray? That would solve that issue, and would also be better for our stats (as I get the stats from Maven Central on our number of downloads)

@atomfrede

This comment has been minimized.

Show comment
Hide comment
@atomfrede

atomfrede Aug 30, 2018

Member
Member

atomfrede commented Aug 30, 2018

@pascalgrimaud

This comment has been minimized.

Show comment
Hide comment
@pascalgrimaud

pascalgrimaud Aug 30, 2018

Member

@atomfrede @jdubois : I look an older version of JHipster randomly: 4.0.5, we had this config before:
https://github.com/jhipster/generator-jhipster/blob/v4.0.5/generators/server/templates/_build.gradle#L7

So I think it was removed, as discussed in this ticket: #6252

Every repository declaration slows down the build, because on missing or dynamic dependencies, Gradle has to look into each one of them in turn. I assume that may of these repos aren't actually necessary. For instance mavenCentral is fully contained in jcenter().

Member

pascalgrimaud commented Aug 30, 2018

@atomfrede @jdubois : I look an older version of JHipster randomly: 4.0.5, we had this config before:
https://github.com/jhipster/generator-jhipster/blob/v4.0.5/generators/server/templates/_build.gradle#L7

So I think it was removed, as discussed in this ticket: #6252

Every repository declaration slows down the build, because on missing or dynamic dependencies, Gradle has to look into each one of them in turn. I assume that may of these repos aren't actually necessary. For instance mavenCentral is fully contained in jcenter().

@atomfrede

This comment has been minimized.

Show comment
Hide comment
@atomfrede

atomfrede Aug 30, 2018

Member
Member

atomfrede commented Aug 30, 2018

@jdubois

This comment has been minimized.

Show comment
Hide comment
@jdubois

jdubois Aug 30, 2018

Member

OK I get it, then For instance mavenCentral is fully contained in jcenter() is not totally true, as we are getting those sync errors... And that's the second time, and we are quite blocked now.

So I'm for migrating back to Maven central

Member

jdubois commented Aug 30, 2018

OK I get it, then For instance mavenCentral is fully contained in jcenter() is not totally true, as we are getting those sync errors... And that's the second time, and we are quite blocked now.

So I'm for migrating back to Maven central

@jdubois

This comment has been minimized.

Show comment
Hide comment
@jdubois

jdubois Aug 30, 2018

Member

At least I'm doing this now to fix the build....

Member

jdubois commented Aug 30, 2018

At least I'm doing this now to fix the build....

@jdubois jdubois closed this in 1ccbab4 Aug 30, 2018

@jdubois

This comment has been minimized.

Show comment
Hide comment
@jdubois

jdubois Aug 31, 2018

Member

The sync process is getting better today, but it's still lacking the latest version.... I'm waiting for it to sync, and if it works I'll revert my commit and switch back to jcenter.

Member

jdubois commented Aug 31, 2018

The sync process is getting better today, but it's still lacking the latest version.... I'm waiting for it to sync, and if it works I'll revert my commit and switch back to jcenter.

@jdubois

This comment has been minimized.

Show comment
Hide comment
@jdubois

jdubois Aug 31, 2018

Member

I'm still not seeing the latest release on jcenter, so I'm going to keep using Maven central:

  • The sync process takes time (which is normal), but this going to make our Travis test fail for Gradle quite often (today it's obvious, but I'm pretty sure we already had this in the past, but didn't understand the root cause)
  • This is also better for our stats on Maven Central, as I get monthly reports from our download stats
  • I don't think this makes any difference for our users

We will just keep jcenter in our Docker Gradle build as this uses a plugin that is only available there.

Member

jdubois commented Aug 31, 2018

I'm still not seeing the latest release on jcenter, so I'm going to keep using Maven central:

  • The sync process takes time (which is normal), but this going to make our Travis test fail for Gradle quite often (today it's obvious, but I'm pretty sure we already had this in the past, but didn't understand the root cause)
  • This is also better for our stats on Maven Central, as I get monthly reports from our download stats
  • I don't think this makes any difference for our users

We will just keep jcenter in our Docker Gradle build as this uses a plugin that is only available there.

@jdubois jdubois added this to the 5.3.0 milestone Sep 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment