Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress png and svg files to speed up page loading #10833

Merged
merged 1 commit into from Nov 27, 2019

Conversation

@sDaniel
Copy link
Contributor

sDaniel commented Nov 26, 2019

using tinypng.com and imageoptim.com
I'm using lossless + lossy compression to get ~54% file size reduction (1.285.389 Byte > 593.343 Byte) where I can't spot the difference.

  • Please make sure the below checklist is followed for Pull Requests.

  • Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

using tinypng.com and imageoptim.com
~54% file size reduction 1.285.389 Byte > 593.343 Byte
@atomfrede

This comment has been minimized.

Copy link
Member

atomfrede commented Nov 27, 2019

Thanks @sDaniel that are huge saving! Congrats to your first contribution.

Copy link
Member

atomfrede left a comment

I can't see any difference 👍

@atomfrede atomfrede merged commit e60afba into jhipster:master Nov 27, 2019
17 checks passed
17 checks passed
ngx-session-cassandra-fr application test suite
Details
JHipster generator unit test suite (10.x, ubuntu-latest)
Details
ngx-mongodb-kafka-cucumber application test suite
Details
JHipster generator unit test suite (12.x, ubuntu-latest)
Details
ngx-couchbase application test suite
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jhipster.generator-jhipster Build #20191126.4 succeeded
Details
jhipster.generator-jhipster (Test jdl-default) Test jdl-default succeeded
Details
jhipster.generator-jhipster (Test jdl-default-jdk8) Test jdl-default-jdk8 succeeded
Details
jhipster.generator-jhipster (Test ms-ngx-gateway-consul) Test ms-ngx-gateway-consul succeeded
Details
jhipster.generator-jhipster (Test ms-ngx-gateway-eureka-oauth2) Test ms-ngx-gateway-eureka-oauth2 succeeded
Details
jhipster.generator-jhipster (Test ms-ngx-gateway-uaa) Test ms-ngx-gateway-uaa succeeded
Details
jhipster.generator-jhipster (Test ngx-h2mem-ws-nol2) Test ngx-h2mem-ws-nol2 succeeded
Details
jhipster.generator-jhipster (Test ngx-mariadb-oauth2-sass-infinispan) Test ngx-mariadb-oauth2-sass-infinispan succeeded
Details
jhipster.generator-jhipster (Test react-default) Test react-default succeeded
Details
jhipster.generator-jhipster (Test react-noi18n-es-ws-gradle-session) Test react-noi18n-es-ws-gradle-session succeeded
Details
jhipster.generator-jhipster (Test webflux-mongodb) Test webflux-mongodb succeeded
Details
@sDaniel

This comment has been minimized.

Copy link
Contributor Author

sDaniel commented Nov 27, 2019

Thanks for the quick merge. Makes me happy :)

@sDaniel sDaniel deleted the sDaniel:compress-images branch Nov 27, 2019
@atomfrede atomfrede mentioned this pull request Nov 27, 2019
0 of 4 tasks complete
@PierreBesson

This comment has been minimized.

Copy link
Contributor

PierreBesson commented Nov 28, 2019

Thanks a lot @sDaniel ! Could you document your process in a text file to PR to https://github.com/jhipster/jhipster-artwork

@atomfrede

This comment has been minimized.

Copy link
Member

atomfrede commented Dec 1, 2019

@sDaniel Can you check jhipster_family_member_1.svg again? it is still quite large compared to the others.

Edit: Seems to be the pattern on the shirt which makes the files much larger, so looks fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.