Upgrade to Angular 9 #11262

wmarques · 2020-02-08T18:21:47Z

Please make sure the below checklist is followed for Pull Requests.
All continuous integration tests are green
Tests are added where necessary
Documentation is added/updated where necessary
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

generators/client/templates/angular/webpack/webpack.common.js.ejs

wmarques · 2020-02-17T12:23:31Z

I couldn't use TestBed.inject instead of TestBed.get because we use mock classes instead of the real service so the typing is not working.

ruddell

I reviewed the code but did not test the newer changes locally. There is a CI issue related to entity screens. I also restarted the CI due to an npm/cloudflare issue (E429 too many requests) which should be fixed now.

generators/client/templates/angular/tsconfig-aot.json.ejs

...ors/client/templates/angular/src/main/webapp/app/layouts/navbar/active-menu.directive.ts.ejs

wmarques · 2020-02-20T12:51:49Z

Thanks @ruddell ! Hope that's good, I tested it on my laptop with some entities...

Let's see if the CI is ok 🙏

pascalgrimaud · 2020-02-21T07:40:35Z

FYI, the CI failed during the packaging phase here

wmarques · 2020-02-25T12:59:18Z

I need a release after jhipster/ng-jhipster#124 is merged and we should - finally - be good 🎉

mshima · 2020-02-25T13:54:33Z

It’s missing tsconfig-aot.json cleanup.

wmarques · 2020-02-25T13:56:42Z

@mshima No I think I removed it, where do you see it ?

mshima · 2020-02-25T14:49:51Z

@mshima No I think I removed it, where do you see it ?

I wasn’t clear. The file should be removed from old projects.
https://github.com/jhipster/generator-jhipster/blob/master/generators/cleanup.js

postpersonality · 2020-02-27T09:26:41Z

Hi. I've applied the changes manually to my existing project and I've noticed lots of warnings like
/src/test/javascript/spec/app/entities/<entity>/<entity>.component.spec.ts is part of the TypeScript compilation but it's unused.
Add only entry points to the 'files' or 'include' properties in your tsconfig.
when doing npm run webpack:build

It was an error in my tsconfig file.

And the second thing I've noticed you have "@angular/common": "9.0.0" in the package.json while there are updates to the 9.0.3.

wmarques · 2020-02-27T09:59:37Z

@postpersonality alright i'll check this out, thanks for reaching up

postpersonality · 2020-02-27T10:27:49Z

There is also

npm WARN @ng-bootstrap/ng-bootstrap@5.2.1 requires a peer of @angular/common@^8.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @ng-bootstrap/ng-bootstrap@5.2.1 requires a peer of @angular/core@^8.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @ng-bootstrap/ng-bootstrap@5.2.1 requires a peer of @angular/forms@^8.0.0 but none is installed. You must install peer dependencies yourself.

during the npm install

I think @ng-bootstrap/ng-bootstrap needs to be updated to 6.0.0

But doing that leads to

npm WARN ng-jhipster@0.12.0 requires a peer of @ng-bootstrap/ng-bootstrap@^5.1.0 but none is installed. You must install peer dependencies yourself.

wmarques · 2020-02-27T10:30:08Z

Looks like 9.0.3 is not ready : angular/angular#35709
I saw this issue on my project so I prefer not upgrading to this version.

postpersonality · 2020-02-27T10:38:33Z

Looks like 9.0.3 is not ready : angular/angular#35709

Thanks for posting this. Got the same problem with the 9.0.3. The 9.0.2 works fine for me.

wmarques · 2020-02-27T15:49:45Z

@postpersonality I don't have the TS warnings. Did you add
"files": ["src/main/webapp/app/app.main.ts"] in tsconfig.app.json ?

wmarques · 2020-02-27T16:45:03Z

I think this is ready for merge.
cc @kaidohallik @vishal423 if you want to check this 😄

vishal423 · 2020-02-28T09:07:07Z

@wmarques, I will try to have a quick pass by today evening or tomorrow.

vishal423

Overall code looks good. I have provided few minor comments.

generators/client/templates/angular/package.json.ejs

generators/client/templates/angular/src/main/webapp/app/polyfills.ts.ejs

vishal423 · 2020-02-28T10:13:13Z

generators/client/templates/angular/src/main/webapp/app/app.main.ts.ejs

@@ -16,6 +16,7 @@
 See the License for the specific language governing permissions and
 limitations under the License.
 -%>
+import './polyfills';


any specific reason to move to this approach or can we follow cli generated code to add it to tsconfig.app.json like
"files": ["src/main.ts", "src/polyfills.ts"],

I just thought it reduce entry points, I don't see why we put the polyfills apart...

can you confirm that it still produces a different bundle for polyfills? If not, then, it's a deviation from current behavior and also wouldn't recommend that.

@wmarques, can you confirm the behavior?

It doesn't produces a different bundle but the polyfill would still be loaded so for me that's not really important, polyfills are always loaded, we don't do differential loading like angular CLI does.

generators/client/templates/angular/tsconfig.json.ejs

vishal423 · 2020-02-28T10:31:15Z

I couldn't use TestBed.inject instead of TestBed.get because we use mock classes instead of the real service so the typing is not working.

In my schematic sample project, I had noticed lint errors/warnings with TestBed.get. Can you check that's not the case here?

mraible

LGTM! I would like to see Angular 9.0.4 if possible.

generators/client/templates/angular/package.json.ejs

mraible · 2020-02-29T16:27:41Z

generators/client/templates/angular/package.json.ejs

+    "@angular/localize": "^9.0.0",
+    "@angular/platform-browser": "9.0.0",
+    "@angular/platform-browser-dynamic": "9.0.0",
+    "@angular/router": "9.0.0",


Angular 9.0.4 is available https://github.com/angular/angular/releases.

mraible · 2020-02-29T23:40:29Z

I'm assigning a bug bounty to this one because it wasn't that straightforward and it's an important feature for JHipster.

generators/client/templates/angular/src/main/webapp/app/polyfills.ts.ejs

pascalgrimaud · 2020-03-01T09:14:54Z

@mraible : there is already a bounty on the issue, but if you think it's not enough, I'm increasing it and remove the bounty on the PR. No need to add bounty on both issue and PR, it can confuse people :p

wmarques · 2020-03-02T13:02:32Z

Thanks @mraible and @vishal423, should be good now 😄 (if the CI god is with me 🙏)

generators/client/templates/angular/package.json.ejs

wmarques · 2020-03-02T13:31:40Z

Only one React build failing 😢

wmarques · 2020-03-02T13:44:21Z

I couldn't use TestBed.inject instead of TestBed.get because we use mock classes instead of the real service so the typing is not working.

In my schematic sample project, I had noticed lint errors/warnings with TestBed.get. Can you check that's not the case here?

Didn't notice anything with npm run lint

wmarques · 2020-03-12T17:06:32Z

Bounty claimed https://opencollective.com/generator-jhipster/expenses/14646

wmarques added the theme: angular label Feb 8, 2020

ruddell reviewed Feb 8, 2020

View reviewed changes

generators/client/templates/angular/webpack/webpack.common.js.ejs Outdated Show resolved Hide resolved

wmarques marked this pull request as ready for review February 17, 2020 12:22

wmarques added 3 commits February 17, 2020 13:24

upgrade to ng9

932409b

Bump TypeScript version to 3.7

55e971f

Use MAIN_SRC_DIR

e156866

wmarques force-pushed the ng9 branch from bbf7b4d to e156866 Compare February 17, 2020 12:24

wmarques added the area: enhancement 🔧 label Feb 17, 2020

ruddell requested changes Feb 17, 2020

View reviewed changes

generators/client/templates/angular/tsconfig-aot.json.ejs Outdated Show resolved Hide resolved

...ors/client/templates/angular/src/main/webapp/app/layouts/navbar/active-menu.directive.ts.ejs Show resolved Hide resolved

Fix tsconfig and renderer and entity generation

f3b8571

wmarques added 2 commits February 24, 2020 13:57

Fix strict mode issues

168d7cf

fix second openFile parameter

6c53866

bump ng-jhipster to 0.12.0

f9bf58f

Remove tsconfig-aot when upgrading

72bd0b2

Bump ng-bootstrap to 6.0.0

e776f77

vishal423 requested changes Feb 28, 2020

View reviewed changes

mraible approved these changes Feb 29, 2020

View reviewed changes

mraible added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $200 https://www.jhipster.tech/bug-bounties/ labels Feb 29, 2020

vishal423 reviewed Mar 1, 2020

View reviewed changes

generators/client/templates/angular/src/main/webapp/app/polyfills.ts.ejs Outdated Show resolved Hide resolved

pascalgrimaud removed $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $200 https://www.jhipster.tech/bug-bounties/ labels Mar 1, 2020

wmarques added 2 commits March 2, 2020 13:37

polish + bump tslint to 6.0.0

a58eb36

bump to 9.0.4 and remove core-js

b6db7ad

vishal423 reviewed Mar 2, 2020

View reviewed changes

generators/client/templates/angular/package.json.ejs Outdated Show resolved Hide resolved

use exact version on @angular/localize

e1cdf4c

pascalgrimaud merged commit 22353e9 into jhipster:master Mar 2, 2020

wmarques deleted the ng9 branch March 2, 2020 13:38

pascalgrimaud added this to the 6.8.0 milestone Mar 3, 2020

This was referenced May 11, 2020

Sorting icon is not changing any more in Angular #11762

Closed

Support strictTemplates in Angular #11763

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to Angular 9 #11262

Upgrade to Angular 9 #11262

wmarques commented Feb 8, 2020 •

edited

wmarques commented Feb 17, 2020

ruddell left a comment

wmarques commented Feb 20, 2020

pascalgrimaud commented Feb 21, 2020

wmarques commented Feb 25, 2020

mshima commented Feb 25, 2020

wmarques commented Feb 25, 2020

mshima commented Feb 25, 2020

postpersonality commented Feb 27, 2020 •

edited

wmarques commented Feb 27, 2020

postpersonality commented Feb 27, 2020 •

edited

wmarques commented Feb 27, 2020

postpersonality commented Feb 27, 2020 •

edited

wmarques commented Feb 27, 2020

wmarques commented Feb 27, 2020

vishal423 commented Feb 28, 2020

vishal423 left a comment

vishal423 Feb 28, 2020

wmarques Feb 28, 2020

vishal423 Mar 1, 2020

vishal423 Mar 2, 2020

wmarques Mar 2, 2020

vishal423 commented Feb 28, 2020

mraible left a comment

mraible Feb 29, 2020

mraible commented Feb 29, 2020 •

edited

pascalgrimaud commented Mar 1, 2020

wmarques commented Mar 2, 2020 •

edited

wmarques commented Mar 2, 2020

wmarques commented Mar 2, 2020

wmarques commented Mar 12, 2020

Upgrade to Angular 9 #11262

Upgrade to Angular 9 #11262

Conversation

wmarques commented Feb 8, 2020 • edited

wmarques commented Feb 17, 2020

ruddell left a comment

Choose a reason for hiding this comment

wmarques commented Feb 20, 2020

pascalgrimaud commented Feb 21, 2020

wmarques commented Feb 25, 2020

mshima commented Feb 25, 2020

wmarques commented Feb 25, 2020

mshima commented Feb 25, 2020

postpersonality commented Feb 27, 2020 • edited

wmarques commented Feb 27, 2020

postpersonality commented Feb 27, 2020 • edited

wmarques commented Feb 27, 2020

postpersonality commented Feb 27, 2020 • edited

wmarques commented Feb 27, 2020

wmarques commented Feb 27, 2020

vishal423 commented Feb 28, 2020

vishal423 left a comment

Choose a reason for hiding this comment

vishal423 Feb 28, 2020

Choose a reason for hiding this comment

wmarques Feb 28, 2020

Choose a reason for hiding this comment

vishal423 Mar 1, 2020

Choose a reason for hiding this comment

vishal423 Mar 2, 2020

Choose a reason for hiding this comment

wmarques Mar 2, 2020

Choose a reason for hiding this comment

vishal423 commented Feb 28, 2020

mraible left a comment

Choose a reason for hiding this comment

mraible Feb 29, 2020

Choose a reason for hiding this comment

mraible commented Feb 29, 2020 • edited

pascalgrimaud commented Mar 1, 2020

wmarques commented Mar 2, 2020 • edited

wmarques commented Mar 2, 2020

wmarques commented Mar 2, 2020

wmarques commented Mar 12, 2020

wmarques commented Feb 8, 2020 •

edited

postpersonality commented Feb 27, 2020 •

edited

postpersonality commented Feb 27, 2020 •

edited

postpersonality commented Feb 27, 2020 •

edited

mraible commented Feb 29, 2020 •

edited

wmarques commented Mar 2, 2020 •

edited