Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jhipster from the URL under the management part #4477

Merged
merged 1 commit into from Nov 17, 2016

Conversation

@gzsombor
Copy link
Contributor

commented Nov 15, 2016

and fix pagination urls to correctly point back.
This 'jhipster' separator doesn't add any functionality to the application, just confuses the thing.

@deepu105

This comment has been minimized.

Copy link
Member

commented Nov 15, 2016

@jdubois added the seperator I guess. Not sure what was the reason so lets wait for his review.

@pascalgrimaud

This comment has been minimized.

Copy link
Member

commented Nov 15, 2016

It was done for security -> I find the ticket #3550

@gzsombor

This comment has been minimized.

Copy link
Contributor Author

commented Nov 15, 2016

The admin functionality is still under /management/ only the jhipster prefix / or suffix is removed from the audit and the log listing

@jdubois

This comment has been minimized.

Copy link
Member

commented Nov 16, 2016

Thanks everyone, first some background on this:

  • All admin features are behind "management" for security
  • Then, I used "management/jhipster" for all JHipster endpoints, so you don't fix them with the Spring Boot actuator admin endpoints

So, concerning this specific change:

  • Only downside is that we mix the JHipster specific endpoints with the Spring Boot "official" endpoints. I'm not sure it can cause any issue, only risk is that Spring Boot does a new endpoint which is the same as us - this is unlikely, but possible
  • And of course I agree with @gzsombor that this is less confusing, and easier.

So +1 from me

@gzsombor gzsombor merged commit 24df82d into jhipster:master Nov 17, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gzsombor gzsombor deleted the gzsombor:remove-jhipster-from-url branch Nov 17, 2016

@jdubois jdubois modified the milestone: 3.12.0 Nov 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.