Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename Angular 2 HTML component files #4501

Closed
wants to merge 957 commits into from
Closed

rename Angular 2 HTML component files #4501

wants to merge 957 commits into from

Conversation

agoncal
Copy link
Contributor

@agoncal agoncal commented Nov 18, 2016

HTML component files should be called the name of the component with an html suffix

Fix #4499

clean up remaining references to `typings` after previous commit switched to npm "@types"
add npm deps to angular-ui-router, ui-router-ng1-to-ng2, ui-router-visualizer
use ng1-to-ng2 ui-router hybrid adapter to bootstrap hybrid app
wait to being routing until ng2 bootstrap is complete

ui-router 1.0 compatibility:
- remove `parent:` declaration for states named `user-management.*`
- replace $stateChange* event handlers with transition hooks
use ui-router-ng2 directives and route to angular 2 components for 'account' states
use `UIRouterModule.forChild({ states: ___ })` to register states
Use hybrid adapter ui-router-ng1-to-ng2
@deepu105
Copy link
Member

you did PR to wrong branch :)

@deepu105 deepu105 closed this Nov 18, 2016
@agoncal
Copy link
Contributor Author

agoncal commented Nov 18, 2016

Gee. Sorry about that. That's what happens when you try new tools (SourceTree). Doing it again....

@jdubois jdubois modified the milestone: 3.12.0 Nov 30, 2016
@deepu105 deepu105 modified the milestones: 3.12.0, Future 4.0 Nov 30, 2016
@deepu105 deepu105 added ng2 and removed ng2 labels Nov 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Angular 2 HTML component files