Upgrading to MapStruct 1.1.0.Final #4539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gunnarmorling thanks. You could also consider to help us to get mapstruct support out of beta 😜 |
|
I'll try to do the best I can :) I'm not sure though what would be needed
to make it happen. Anything you miss from MapStruct in order to call your
support final?
|
|
I guess for now its mostly quirks in IDE and some issues with handling complex relationships @jdubois might know better |
|
Yes we have 2 kinds of issues: IDE configuration: I've spent a lot of time on this, I have no idea how to do it correctly. You can have a look at https://jhipster.github.io/configuring-ide/ (look for the "IDE profile" at the bottom), and you can contribute changes here. And we also have mapping issues, like here, but this isn't really a MapStruct issue, it's mostly us having trouble to use it correctly, with some corner cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the versions of MapStruct I found. I hope I didn't miss anything?