New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve compose files by using DNS alias #5135
Conversation
- remove all container_name, links and external_links to use DNS alias instead - add npm test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested a full setup and it worked without problems. But this might need more testing so that we don't break anything.
@pascalgrimaud I have notice a new docker-compose feature that could replace our JHipster Sleep by using docker healthchecks and depends_on : https://docs.docker.com/compose/compose-file/#/dependson Also big news, I have managed to deploy a docker-compose with a full microservice stack to a swarm, with scaling working correctly. So when I have the time I will finally be able to add the option to generate a docker-compose for "prod". |
May I propose you smething like this? |
@PierreBesson : interesting! so we need to upgrade the docker-compose file version to 2.1+. I think it can be done on another PR to be clearer @romaindequidt : sure, it looks better than what I did:
|
@pascalgrimaud I wanted to PR our PR but i do not if i can (i'm not jhipster member and I did find your branch :/) |
@romaindequidt : so if you want to PR on my branch, just go to this link pascalgrimaud/generator-jhipster@docker-1.13...romaindequidt:docker-1.13 |
Avoid duplacting code using shared behaviours
LGTM so @pascalgrimaud I let you merge this when the PR on your PR is also merged :-) |
@jdubois @pascalgrimaud Are you sure to force everyone to upgrade their Docker client version? |
Thanks @romaindequidt I didn't notice that!!!
I would stay with 1.13, people need to upgrade, or use an up-to-date cloud. @pascalgrimaud what's your opinion? |
In fact, this PR removes But I made this PR jhipster/jhipster.github.io#386 to update the Docker client API to 1.13 |
@pascalgrimaud Ok, if it's not this PR it will be the next one ;) |
Yes plz @romaindequidt ! |
@romaindequidt Yes a PR would be very much appreciated ! Do not worry about "background compatibility" as for us docker-compose is first and foremost a "dev" tool (no meaningful way to manage your "prod" with it before the last version). |
Related to #5128
@PierreBesson : if you have time to review it
@jdubois / @mraible : I know you do a lot of demos, so I hope you can test this. I don't want to break something!