Add service layer

[ivanmonteiro]

Give the possibility to generate service layer

Fix #275

• Please make sure the below checklist is followed for Pull Requests.

• All continuous integration tests are green

• Tests are added where necessary

• Documentation is added/updated where necessary

• Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

[nicolas63]

Already in draft mode or you need review ?

[ivanmonteiro]

Already in draft mode or you need review ?

I still have to solve some conflicts and fix. Hope to provide a review-able PR in a couple of days.

[ivanmonteiro]

Already in draft mode or you need review ?

I still have to solve some conflicts and fix. Hope to provide a review-able PR in a couple of days.

I think it is ready for review.
The latest commit (service files/namespace refactoring) added lots of changes (mostly namespace changes).
If you think it is better to split this PR into smaller ones let me know.

[nicolas63]

With jdl we can omit service creation with service all with serviceImpl except Employee, Job
In your case the controller is good but the service is generated

[nicolas63]

Maybe we can rename Infrastructure folder in WebProject to Configuration ? This can be done in other PR

[nicolas63]

with new project there is nothing to add in dockerfile.ejs ?

[ivanmonteiro]

with new project there is nothing to add in dockerfile.ejs ?

I'll check the dockerfile, it probably needs some changes

With jdl we can omit service creation with service all with serviceImpl except Employee, Job
In your case the controller is good but the service is generated

I'll check what is going on.

[nicolas63]

Maybe we can rename Infrastructure folder in WebProject to Configuration ? This can be done in other PR

I will do it

[ivanmonteiro]

Maybe we can rename Infrastructure folder in WebProject to Configuration ? This can be done in other PR

Agree, it is better on other PR, after this PR is merged, because some files at that folder were moved.

I will do it

Allright.

[ivanmonteiro]

with new project there is nothing to add in dockerfile.ejs ?

I just changed the dockerfile, now it restores the new ..csproj projects

# Restore dependencies of .net core projects taking advantage of docker layer caching
COPY src/*/*.csproj ./src/
RUN for file in $(ls src/*.csproj); do mkdir -p ${file%.*} && mv $file ${file%.*}; done
RUN dotnet restore "src/JhipsterSampleApplication/JhipsterSampleApplication.csproj"

[ivanmonteiro]

With jdl we can omit service creation with service all with serviceImpl except Employee, Job
In your case the controller is good but the service is generated

Fixed this with the latest commit

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
0.0% Duplication

[nicolas63]

Everything looks good to me. It's a really nice job, thanks for your help on the project 😃

[ivanmonteiro]

Claimed bounty https://opencollective.com/generator-jhipster/expenses/23848

[pascalgrimaud]

@ivanmonteiro : just approved :)