Skip to content

PGN generator #2

Merged
merged 4 commits into from Jun 18, 2011

2 participants

@2sb18
2sb18 commented Jun 16, 2011

Hi Jeff,

I trying to learn JavaScript. I want to write a program like BookUp, and I thought I was going to have to write a validator until I came across chess.js. I've implemented the PGN generator. Please let me know if there's anything that I could change to make the code better/cleaner.

Steve.

2sb18 added some commits Jun 16, 2011
@2sb18 2sb18 - added the method pgn() to generate PGN output c3737e5
@2sb18 2sb18 - renamed variables in pgn() from camel-case to underscore notation.
- added an info() function that takes PGN header information.
- updated pgn() to output header information.
- updated pgn() to optionally take a maximum width and a newline character.
- added tests for pgn(), which also tests info().
84991c9
@2sb18 2sb18 Added notes on .info() and .pgn() methods. d44ad5b
@2sb18 2sb18 fixed small mistake. b1efabf
@jhlywa jhlywa merged commit d890f16 into jhlywa:master Jun 18, 2011
@jhlywa
Owner
jhlywa commented Jun 18, 2011

Thanks for the patches Steve! I've merged your changes into the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.