diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index 67105c53..31972b0f 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -2,15 +2,37 @@ SoluciĆ³n al reto: -Nombre: -Usuario Platzi: +There were two main blocks that I found: + +* The tests were giving an error message. For this one I got help from the community for a given solution to use another method for mounting the specific component for the test + +* At the deployment stage, there was an error of incompatibility of react versions between two libraries, I reviewed the logs and decide to roll back to a previos version of react from 18 to 16 + +The API url is pointing to an endpoint of a service I have deployed in heroku. + +The app is deployed to github pages, I added a file deploy.yml in the github workflows, so in every push to github the app will re-deploy. + +I added an script in the index.html file for the social media icons from font awesome. +___ + +## Deployed app at: + +https://jho3r.github.io/react-eth-challenge/ +___ +## Info + +Nombre: Jhoer Sebastian Perez Castillo +Usuario Platzi: jho3r +Link Usuario Platzi: https://platzi.com/p/jho3r/ + +___ ## Reto: -- [ ] Primer problema -- [ ] Segundo problema -- [ ] Tercer problema -- [ ] Cuarto Problema -- [ ] Quinto Problema -- [ ] Sexto Problema -- [ ] Septimo Problema +- [x] Primer problema +- [x] Segundo problema +- [x] Tercer problema +- [x] Cuarto Problema +- [x] Quinto Problema +- [x] Sexto Problema +- [x] Septimo Problema