Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemenation of gmond_python_modules #79

Closed
pramodhkp opened this issue Oct 12, 2017 · 2 comments
Closed

Implemenation of gmond_python_modules #79

pramodhkp opened this issue Oct 12, 2017 · 2 comments
Assignees

Comments

@pramodhkp
Copy link

Hi,

Would you be interested in a PR for adding gmond_python_modules support for this module? https://github.com/ganglia/gmond_python_modules

I'm extending this module for my purposes, and would like to submit a PR if it's useful.

Thanks

@jhoblitt
Copy link
Owner

#77 implements this.

@frizop
Copy link
Collaborator

frizop commented Sep 10, 2020

If you check out my comments on the closed PR #77 this is roughly what I think we should do if this is needed.

Specifically we should answer this: #77 (comment)

Which has working tests: #77 (comment)

etc etc. Let me know what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants