Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renewing Puppet Forge Approved Status #80

Closed
lionce opened this issue Feb 4, 2019 · 7 comments
Closed

Renewing Puppet Forge Approved Status #80

lionce opened this issue Feb 4, 2019 · 7 comments

Comments

@lionce
Copy link

lionce commented Feb 4, 2019

Hey @jhoblitt,

Here at puppetlabs, we are currently going through all of our Approved modules on the Puppet Forge. We have some feedback for your module if you would be interested in retaining the approved status. If you are keen on keeping your approved status please ensure you respond as soon as you possibly can.

Many Thanks
The Puppet Approvals Committee.

@jhoblitt
Copy link
Owner

jhoblitt commented Feb 4, 2019

Please!

@lionce
Copy link
Author

lionce commented Feb 5, 2019

Hello @jhoblitt ,

Thank you for your prompt reply. In order for this module to remain approved, the following areas need to be updated:
• Add Puppet 5+6 support
• README should conform to documentation standards (see here)
• Module should be under active maintenance (within last 6 months)

For additional information on Puppet Forge Approved criteria please see here
Thank you for your cooperation. If you have any questions or concerns, don’t hesitate to let me know.

Cheers!

@frizop
Copy link
Collaborator

frizop commented Sep 10, 2020

Howdy @lionce just wondering now that there's some new modern code in this repo what the status will be updated to be? I'll note for both @jhoblitt and myself, the README.md seems a bit dated now (but most info is still accurate) and we should work on updating it. I'll also note to @jhoblitt we should look into doing a release soon, ie: the whole reason I did the work on this module 💯

@jhoblitt
Copy link
Owner

I'm planning to cut a new major release that drops puppet < 5 and el5 soonish.

@jhoblitt
Copy link
Owner

I'm currently experiencing rake target rage trying to get travis deployment to the forge up and running...

@frizop
Copy link
Collaborator

frizop commented Sep 10, 2020

w00t, looks like you figured it out? I'm just now getting back to this, looks like testing is all valid locally and I see a forge release 🎉

@jhoblitt
Copy link
Owner

Yes, finally, the pdk generated .travis.yml isn't in a working state out of the box and the template isn't very flexible but it seems to be finally working. https://forge.puppet.com/jhoblitt/ganglia/3.0.3/readme is the version that finally made it to the forge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants