restriction of maximum clusters is only 1 ?

[eylenth]

why is the maximum clusters in the ganglia_validate_clusters function only be 1 ?

puppet-ganglia/lib/puppet/parser/functions/ganglia_validate_clusters.rb

Lines 55 to 57 in 9a9aaa5

	unless args.length == 1
	raise Puppet::ParseError, "ganglia_validate_clusters(): wrong number of arguments (#{args.length}; must be 1)"
	end

on our environment we have like 9 clusters configured in the /etc/ganglia/gmetad.conf configuration file.
We used an older version of the ganglia puppet module, when the ganglia_validate_clusters maximum function didn't take place.

[Debilski]

It’s also not clear why it is declared as a Tuple[Hash]. If I change it to Array[Hash], it seems to be ok with multiple clusters.

puppet-ganglia/manifests/gmetad.pp

Lines 19 to 21 in ffe3de0

	class ganglia::gmetad (
	Enum['on', 'off'] $all_trusted = 'off',
	Tuple[Hash] $clusters = [{ 'name' => 'my cluster', 'address' => 'localhost' }],

[jhoblitt]

@eylenth #ganglia_validate_clusters should have an arity of 1 as it only works on a single array.
@Debilski Looks like that came in as part of a cleanup PR. I would be happy to merge a fix.

[eylenth]

@Debilski it is working now with your PR.

[jhoblitt]

Fix released as part of https://forge.puppet.com/modules/jhoblitt/ganglia/4.0.0/readme