Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to set ganglia->globals->{deaf, host_dmax, send_metadata_interval} as well as use udp_send_channel->bind_hostname #18

Merged
merged 5 commits into from
Nov 25, 2014

Conversation

goungy
Copy link
Contributor

@goungy goungy commented Jun 26, 2014

We needed to be able to set the following settings in gmond.conf and tested the provided patches under CentOS6.5:
globals {
...
deaf = yes
...
host_dmax = 691200 /_secs */
...
send_metadata_interval = 60 /_secs */
}

udp_send_channel {
...
bind_hostname = yes
...
}

…gmond.conf

[EL6] Adding possibility to set ganglia->globals->deaf parameter for
gmond.conf
… for gmond.conf

[EL6] Adding possibility to set ganglia->globals->host_dmax parameter
for gmond.conf
…val for gmond.conf

[EL6] Adding possibility to set ganglia->globals->send_metadata_interval
for gmond.conf
…ond.conf

[EL6] Adding possibility to set udp_send_channel >bind_hostname in
gmond.conf
@jhoblitt
Copy link
Owner

I'm happy to merge this functionality but the parameter names feel longer than in necessary. How about dropping the ganglia_ prefix? That would make them orthogonal with the cluster_ params.

I realize the rspec tests in this module are pretty spartan but could you add the new params to the README?

…ion in the README

Renaming ganglia_globals_* variables to globals_* and adding description
in the README
@goungy
Copy link
Contributor Author

goungy commented Jun 27, 2014

Thanks for your input and fast reply.
Agreed. Renamed ganglia_globals_* to globals_* and added description of the new settings in README.md.
I insist these new variables will only impact RHEL6/CentOS6 servers as I have modified the RHEL6 erb template only.
No impact/added value for other OSes, which means not all OSes have the same level of configurability after my commits.

@@ -49,6 +55,7 @@ This class manages the configurtion of the Ganglia `gmond` daemon.
$udp_send_channel = [
{ port => 8649, host => 'test1.example.org', ttl => 2 },
{ port => 8649, host => 'test2.example.org', ttl => 2 },
{ bind_hostname => "yes", host => 'test3.example.org', ttl => 1 },
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W/S

@jhoblitt
Copy link
Owner

I'm recovering from surgery and only have limited use of both hands for typing for another week. Don't worry about adding rspec tests for the moment as long as the existing suite continues to pass; I will take care of it when I can.

Could you update all of the gmond templates?

@NoodlesNZ
Copy link
Contributor

I have taken this on as @goungy seems to have abandoned this. I'm just waiting for @jhoblitt to merge PR #27 as I have used scope.lookupvar() to solve the scope problems in future parser. I will add a new PR soon.

@jhoblitt jhoblitt merged commit 1095fc9 into jhoblitt:master Nov 25, 2014
jhoblitt pushed a commit that referenced this pull request Nov 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants