Removes trailing whitespace #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A number of files contained trailing whitespace, this has been removed with the following perl one-liner. perl -pi -e 's/ +$//' * Not having whitespace prevents confusing diff outputs such as the following. #3 (diff)
|
I suspect the trailing w/s was largely from the original conf files but I'll go ahead and merge the entire PR. This module really needs some TLC. |
|
BTW - the email address used for the git commits doesn't seem to match your github account. |
|
Hey thanks for pointing that out I did this from my work where we mainly use an internal git server. Is this an issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of files contained trailing whitespace, this has been removed
with the following perl one-liner.
perl -pi -e 's/ +$//' *
Not having whitespace prevents confusing diff outputs such as the
following.
#3 (diff)
The diff changes on the PR may seem a bit crazy with blocks seemingly removed and re-added but if you view with the following URL or do
git diff --ignore-space-at-eolyou'll see it's just space removal.https://github.com/jhoblitt/puppet-ganglia/pull/20/files?w=1