Fix scope problem for gmetad config

[NoodlesNZ]

With future parser there is a scope problem in the gmetad.conf.erb. Because the variable "clusters" is defined in ganglia::gmetad and the template is in ganglia::gmetad::config it is not in the same scope. By inheriting ganglia::gmetad this fixes the problem.

[NoodlesNZ]

Also found the problem in ganglia::web::config (port/ip from ganglia::web not in the scope that the template is in)

[jhoblitt]

Inheriting the base class to get at it's variables is a bit of an anti-pattern in puppet. A better approach would be to use scope.lookupvar in the ERB templates. See: https://docs.puppetlabs.com/guides/templating.html#out-of-scope-variables

EPP templates won't have this problem but it's going to be awhile before we can rely on puppet 4 features.

[jhoblitt]

BTW - the scope[] form would be fine. I'm OK with dropping 2.7.x support.

[NoodlesNZ]

I'm open to suggestions, I wasn't keen on using inherits, but I figured it's already being used elsewhere in puppet-ganglia so it should be ok for now.

I can refactor with scope[] if that's the way you want to go

[NoodlesNZ]

I started rewriting it to use scope[], but EPEL6 is still on puppet 2.7.x. Might be worth hanging on to 2.7.x support for a while.

[jhoblitt]

Sounds completely reasonable. Supposedly EPEL6 is going to stay with
2.7.x forever.

[NoodlesNZ]

Ok, I'll use scope.lookupvar() instead.

[jhoblitt]

Thanks for working on this!