Added additional parameters to gmetad #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. I'll merge it when the CI run finishes. |
|
Thanks Josh. Any thought on refactoring to split off the params? It shouldn't be that hard, I'm sure I can knock it out in no time. |
|
Unless we want to split up the params class per component, there's not really an alternative to prefixing the variable names. In the distant future when ERB can be replaced with EPP, this problem will half go away as you have to pass a hash of "variables" into the template. |
jhoblitt
pushed a commit
that referenced
this pull request
Nov 24, 2014
Added additional parameters to gmetad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have the need to change the user that gmetad runs as under CentOS 6.x, so I exposed all the params for gmetad. This could probably be cleaned up so gmetad has its own params file (so we can drop the gmetad_ prefix on variables), but this works so far. I also haven't validated gmetad_case_sensitive_hostnames as I'm not entirely sure how I should do this (as it needs to be an integer).